Skip to content

fix: gracefully handle exceptions in an RPC invoke #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xFA11 merged 3 commits into from
May 19, 2021
Merged

fix: gracefully handle exceptions in an RPC invoke #846

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e939b3
fix: gracefully handle exceptions in RPC invoke
0xFA11 May 19, 2021
25d3922
update warning log
0xFA11 May 19, 2021
60608f5
print Unity exception log
0xFA11 May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion com.unity.multiplayer.mlapi/Runtime/Messaging/RpcQueue/RpcQueueProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
using Unity.Profiling;
using MLAPI.Configuration;
using MLAPI.Profiling;
using MLAPI.Logging;
using UnityEngine;

namespace MLAPI.Messaging
{
Expand Down Expand Up @@ -60,7 +62,19 @@ public void ProcessReceiveQueue(NetworkUpdateStage currentStage, bool isTesting)

if (!isTesting)
{
m_NetworkManager.InvokeRpc(currentQueueItem);
try
{
m_NetworkManager.InvokeRpc(currentQueueItem);
}
catch (Exception ex)
{
Debug.LogException(ex);

@SamuelBellomo SamuelBellomo May 19, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if there's an easy way to include a context object here. If no easy way, disregard this comment

@0xFA11 0xFA11 May 19, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't worry, you'll (users will) still get the full call-stack in the console with this exception log :)


if (NetworkLog.CurrentLogLevel <= LogLevel.Normal)
{
NetworkLog.LogWarning($"A {currentQueueItem.QueueItemType} threw an exception while executing! Please check Unity logs for more information.");
}
}
Comment thread
LukeStampfli marked this conversation as resolved.
}

ProfilerStatManager.RpcsQueueProc.Record();
Expand Down