ci: enable standards check on UTP too - #837
Merged
Merged
Conversation
0xFA11
commented
May 17, 2021
| parser.add_argument("--tool-path", default="dotnet-format") | ||
| parser.add_argument("--project-path", default="testproject") | ||
| parser.add_argument("--project-glob", default="Unity.Multiplayer.MLAPI*.csproj") | ||
| parser.add_argument("--project-glob", default="Unity.Multiplayer*.csproj") |
Contributor
Author
There was a problem hiding this comment.
this is the actual change that causes UTP to be included in checks as well.
wackoisgod
approved these changes
May 18, 2021
0xFA11
enabled auto-merge (squash)
May 18, 2021 19:11
SamuelBellomo
added a commit
that referenced
this pull request
May 19, 2021
* develop: fix: gracefully handle exceptions in an RPC invoke (#846) fix: Fixing utp license file for legal (#843) ci: enable standards check on UTP too (#837) refactor: NetworkBehaviour.NetworkObject no longer throws an exception (#838) fix: revert #830 (#840) test: converting the manual rpc tests over to an automated unit test (#830)
SamuelBellomo
added a commit
that referenced
this pull request
May 21, 2021
…player-object-get * develop: test: manual connection approval to fully automated connection approval testing (#839) test: manual rpc tests to automated fixed revision (#841) fix: CleanDiffedSceneObjects was not clearing PendingSoftSyncObjects (#834) feat: NetworkTransform now uses NetworkVariables instead of RPCs (#826) fix: gracefully handle exceptions in an RPC invoke (#846) fix: Fixing utp license file for legal (#843) ci: enable standards check on UTP too (#837) refactor: NetworkBehaviour.NetworkObject no longer throws an exception (#838) fix: revert #830 (#840) test: converting the manual rpc tests over to an automated unit test (#830) # Conflicts: # com.unity.multiplayer.mlapi/Tests/Runtime/MultiInstance/MultiInstanceHelpers.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we are already running
standards --checkoverUnity.Multiplayer.MLAPI*.csprojprojects.this PR changes search glob to
Unity.Multiplayer*.csprojand now standard check also includes UTP.(I also ran
standards.py --fixlocally too, all these changes are coming from that)