Skip to content

feat: adding option for NetworkTransform to sync the server's position of NetworkObject not the owner's - #835

Closed
EamonHeffernan wants to merge 4 commits into
Unity-Technologies:developfrom
EamonHeffernan:master
Closed

feat: adding option for NetworkTransform to sync the server's position of NetworkObject not the owner's#835
EamonHeffernan wants to merge 4 commits into
Unity-Technologies:developfrom
EamonHeffernan:master

Conversation

@EamonHeffernan

@EamonHeffernan EamonHeffernan commented May 16, 2021

Copy link
Copy Markdown

Added bool option to sync server position.
Implements the same system for a network transform with interp and teleporting.
Syncs and interps the server position on all clients including the Owner. Used for completely server authoritative use cases.

@unity-cla-assistant

unity-cla-assistant commented May 16, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jeffreyrainy

jeffreyrainy commented May 16, 2021

Copy link
Copy Markdown
Contributor

Thank you for the submission! There's other work being done at the moment on NetworkTransform, so it might not end up being merged as-is. But I've added reviewers that know about the other work, and we'll be sure to take into account the requirements.

@SamuelBellomo

SamuelBellomo commented May 17, 2021

Copy link
Copy Markdown
Contributor

Hello hello, I believe this is already covered in this PR here
#826
In "CanUpdateTransform()" we check for authority==server and if IsServer to determine if we can update the network position, rotation and scale. It also won't allow clients to update a server authoritative transform.
Did I miss anything?

@EamonHeffernan

EamonHeffernan commented May 18, 2021

Copy link
Copy Markdown
Author

Thank you. Sorry about that

@SamuelBellomo

SamuelBellomo commented May 18, 2021

Copy link
Copy Markdown
Contributor

Thank you. Sorry about that

Oh you don't have to be sorry about that at all! It's great you're adding confirmation that we're going in the right direction in our new design :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EamonHeffernan @unity-cla-assistant @jeffreyrainy @SamuelBellomo