refactor: Unified spawn handling - #707
Closed
Lutz89 wants to merge 16 commits into
Closed
Conversation
Writing and reading the spawn data is now centralized within the NetworkSpawnManager.
Author
|
@TwoTenPvP |
TwoTenPvP
self-requested a review
April 7, 2021 15:50
Contributor
|
Will get to reviewing this |
…nity.multiplayer.mlapi into unified-spawn # Conflicts: # com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs # com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs # com.unity.multiplayer.mlapi/Runtime/SceneManagement/NetworkSceneManager.cs
…nity.multiplayer.mlapi into unified-spawn # Conflicts: # com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs # com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs # com.unity.multiplayer.mlapi/Runtime/SceneManagement/NetworkSceneManager.cs
…nity.multiplayer.mlapi into unified-spawn # Conflicts: # com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs # com.unity.multiplayer.mlapi/Runtime/SceneManagement/NetworkSceneManager.cs
Member
|
Will be reviewing over the differences, but the same concept has been applied in PR 756 so before anyone continues to update this PR realize the effort was noticed and has been applied in a similar fashion! It was an over-all good idea to unify this area of code! 👍 |
Member
|
Closing this pull request as the core concepts were applied in this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing and reading the spawn data is now centralized within the NetworkSpawnManager.
See PR 703