ci: streamline PR and nightly CI jobs - #671
Conversation
| flavor: {{ test_platforms.first.flavor}} | ||
| commands: | ||
| - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm | ||
| - {% if platform.name == "centos" %}DISPLAY=:0 {% endif %}upm-ci project test -u {{ test_editors.first }} --type vetting-tests --package-filter {{ package.name }} --platform editmode |
There was a problem hiding this comment.
I think you have a left-over artifact here of when this was doing multiple package validation... {{ package.name }} likely won't resolve since you no longer define this inside a for loop for each package...
There was a problem hiding this comment.
I may not understand. This is how it looks like when it it's expanded (using the Yamato yaml linter). Should we be expecting something else? I may just be confused.
validate_com.unity.multiplayer.mlapi_win_2021.1:
name : Validate Package com.unity.multiplayer.mlapi - 2021.1 on win
agent:
type: Unity::VM
image: package-ci/win10:stable
flavor: b1.large
commands:
- npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
- upm-ci project test -u 2021.1 --type vetting-tests --package-filter com.unity.multiplayer.mlapi --platform editmode
artifacts:
logs:
paths:
- "upm-ci~/test-results/**/*"
dependencies:
- .yamato/project-pack.yml#pack_testproject
validate_com.unity.multiplayer.transport.utp_win_2021.1:
name : Validate Package com.unity.multiplayer.transport.utp - 2021.1 on win
agent:
type: Unity::VM
image: package-ci/win10:stable
flavor: b1.large
commands:
- npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
- upm-ci project test -u 2021.1 --type vetting-tests --package-filter com.unity.multiplayer.transport.utp --platform editmode
artifacts:
logs:
paths:
- "upm-ci~/test-results/**/*"
dependencies:
- .yamato/project-pack.yml#pack_testproject
There was a problem hiding this comment.
When you added the package for loop on line 8 it fixed this problem. This comment was before that was added. Looks perfect now!
JesseOlmer
changed the title
|
Overall looks pretty good - I'm excited for the optimizations. Our repo is in a bit of an odd spot where we have multiple packages, but we only run tests for 1 of them right now since that's the only one we ship. Nevertheless, we want to be setup to easily enable the other one as soon as we need it. |
2 participants
Updates to build scripts: