ci: Add code coverage that depends on the pack job - #633
Merged
Conversation
This reverts commit ec770e6.
JesseOlmer
approved these changes
Mar 16, 2021
| # for validation | ||
| test_editors: | ||
| - 2021.1 | ||
| - 2021.2 |
Contributor
There was a problem hiding this comment.
These changes were already made in the release branch - they're pending merge back to develop so it'd make that merge easier if you don't add these here :)
| commands: | ||
| - pip install unity-downloader-cli --upgrade --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple | ||
| - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm | ||
| - unity-downloader-cli -u trunk -c editor --wait --fast |
Contributor
There was a problem hiding this comment.
A lot of the other "one version" jobs just use {{ test_editors.first }} to keep all the editor configuration in one place. I don't feel strongly one way or the other, but might be a bit odd in the future to have coverage run against a different version.
Contributor
Author
There was a problem hiding this comment.
Plan is to run this on trunk to start out with to ensure we're liking it. If it's good, we can expand to other versions/branches
JesseOlmer
changed the title
This reverts commit f44173b.
JesseOlmer
enabled auto-merge (squash)
March 16, 2021 16:51
mattwalsh-unity
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will introduce a single build job that depends on the package pack job. The code coverage runs and generates a coverage report that looks like this: https://yamato-artifactviewer.prd.cds.internal.unity3d.com/2b46863c-27b1-4b98-9819-578e1ee01ec6%2Flogs%2Fupm-ci~%2Ftest-results%2Fisolation-5820322-com.unity.multiplayer.mlapi%2FReport/index.htm