fix: remove NetworkManager.Singleton dependencies - #625
Merged
Conversation
This removes the NetworkManager.Singleton dependencies from within the RpcQueueContainer and RpcQueueProcessor classes. This further strengthens the RPC Queue system as a whole, will allow for multiple instances if RpcQueueContainer, removes a limitation I set in NetworkWriter.ReadAndWrite, and provides unit testing capabilities required for new RPC Queue unit Tests.
NoelStephensUnity
marked this pull request as draft
March 15, 2021 22:15
NoelStephensUnity
marked this pull request as ready for review
March 15, 2021 22:31
0xFA11
reviewed
Mar 15, 2021
…eContainer.cs Good catch! Co-authored-by: M. Fatih MAR <[email protected]>
Looks like there were some remaining NumberOfRPCsSent vs RpcSent conversions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor passes the RpcQueueContainer into the RpcQueueProcessor in order to completely remove the RpcQueueContainer's dependencies on the NetworkManager.Singleton.
This refactor removes RpcQueueContainer 's dependencies upon the NetworkManager.Singleton by passing the instance of the NetworkManager that constructed it via the constructor.
This should remove all dependencies from NetworkManager.Singleton from the entire Rpc Queue System.
Refactored the constructor and made the class disposable.
Simplified-Improve the constructor process.
Carried previous suggestions forward from reverted release/0.1.0 PR