Skip to content

fix: Add RequireComponent attribute to NetworkNavMeshAgent. #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattwalsh-unity merged 1 commit into from
Mar 15, 2021
Merged

fix: Add RequireComponent attribute to NetworkNavMeshAgent. #615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.multiplayer.mlapi/Prototyping/NetworkNavMeshAgent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace MLAPI.Prototyping
/// A prototype component for syncing NavMeshAgents

@mattwalsh-unity mattwalsh-unity Mar 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NavMeshAgents -> NetworkNavMeshAgents, keeps grep clean

@LukeStampfli LukeStampfli Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is fine. NetworkNavMeshAgent is a component to sync a regular NavMeshAgent.

/// </summary>
[AddComponentMenu("MLAPI/NetworkNavMeshAgent")]
[RequireComponent(typeof(NavMeshAgent))]

@mattwalsh-unity mattwalsh-unity Mar 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this need to be ?

Suggested change
[RequireComponent(typeof(NavMeshAgent))]
[RequireComponent(typeof(NetworkNavMeshAgent))]

@LukeStampfli LukeStampfli Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this should be NavMeshAgent. The NetworkNavMeshAgent component requires that there also is a NavMeshAgent on the same object. That's why we are using this attribute.

@mattwalsh-unity mattwalsh-unity Mar 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is referring to the private NavMeshAgent m_Agent; in NetworkNavMeshAgent.cs

public class NetworkNavMeshAgent : NetworkBehaviour
{
private NavMeshAgent m_Agent;
Expand Down