fix: Add RequireComponent attribute to NetworkNavMeshAgent. - #615
Merged
mattwalsh-unity merged 1 commit intoMar 15, 2021
Merged
Conversation
| @@ -10,6 +10,7 @@ namespace MLAPI.Prototyping | |||
| /// A prototype component for syncing NavMeshAgents | |||
Contributor
There was a problem hiding this comment.
NavMeshAgents -> NetworkNavMeshAgents, keeps grep clean
Contributor
Author
There was a problem hiding this comment.
I think this comment is fine. NetworkNavMeshAgent is a component to sync a regular NavMeshAgent.
| /// A prototype component for syncing NavMeshAgents | ||
| /// </summary> | ||
| [AddComponentMenu("MLAPI/NetworkNavMeshAgent")] | ||
| [RequireComponent(typeof(NavMeshAgent))] |
Contributor
There was a problem hiding this comment.
Wouldn't this need to be ?
Suggested change
| [RequireComponent(typeof(NavMeshAgent))] | |
| [RequireComponent(typeof(NetworkNavMeshAgent))] |
Contributor
Author
There was a problem hiding this comment.
No this should be NavMeshAgent. The NetworkNavMeshAgent component requires that there also is a NavMeshAgent on the same object. That's why we are using this attribute.
Contributor
There was a problem hiding this comment.
Ah, this is referring to the private NavMeshAgent m_Agent; in NetworkNavMeshAgent.cs
mattwalsh-unity
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkNavMeshAgent expects a NavMeshAgent and throws a null ref if it's not there. So this attribute should have been there to prevent user error.