fix: fixing the number of connections counter to be correctly named and function properly - #613
Merged
mattwalsh-unity merged 2 commits intoMar 15, 2021
Conversation
kvassall-unity
requested review from
0xFA11,
Rosme,
becksebenius-unity and
mattwalsh-unity
March 12, 2021 19:32
Rosme
approved these changes
Mar 15, 2021
| newModule.m_DetailCounters = counterListFactoryDelegate(); | ||
| var newModule = new MLAPIProfilerModuleData | ||
| { | ||
| m_Name = moduleName, m_ChartCounters = counterListFactoryDelegate(), m_DetailCounters = counterListFactoryDelegate(), |
Contributor
There was a problem hiding this comment.
Nit but I'd suggest the setters should be on their own lines
becksebenius-unity
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: fixing the number of connections counter to be correctly named and function properly