fix: fixing the number of connections counter to be correctly named a… - #610
Closed
kvassall-unity wants to merge 2 commits into
Closed
fix: fixing the number of connections counter to be correctly named a…#610kvassall-unity wants to merge 2 commits into
kvassall-unity wants to merge 2 commits into
Conversation
…nd function properly
kvassall-unity
requested review from
0xFA11,
Rosme,
becksebenius-unity and
mattwalsh-unity
March 12, 2021 17:57
Rosme
approved these changes
Mar 12, 2021
Rosme
approved these changes
Mar 12, 2021
becksebenius-unity
approved these changes
Mar 12, 2021
Rosme
approved these changes
Mar 15, 2021
|
Please make sure you target release/0.1.0 |
Contributor
Author
There are two PRS See: |
|
I don't think you should make two PRs. I believe release will be merge into develop at some point. @MFatihMAR @mattwalsh-unity can you confirm? |
Contributor
|
we should target |
Contributor
Author
|
This pr was older, approved and already set to develop. We can close this if we want. But the release pr is the more important one. |
Contributor
Author
|
Closing since the release now has this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd function properly