fix: console ci all green / replace maxframes with timeout seconds (backport) - #1752
Merged
Conversation
0xFA11
enabled auto-merge (squash)
February 25, 2022 07:15
0xFA11
force-pushed
the
backport-1543
branch
from
February 25, 2022 16:54
de10680 to
9f46bb5
Compare
0xFA11
commented
Feb 25, 2022
|
|
||
| int nextFrameNumber = Time.frameCount + 2; | ||
| yield return new WaitUntil(() => Time.frameCount >= nextFrameNumber); | ||
| yield return MultiInstanceHelpers.WaitForMessageOfType<CreateObjectMessage>(m_ClientNetworkManagers[0]); |
0xFA11
commented
Feb 25, 2022
| Object.Destroy(serverClientPlayerResult.Result.gameObject); | ||
|
|
||
| yield return null; | ||
| yield return MultiInstanceHelpers.WaitForMessageOfType<DestroyObjectMessage>(m_ClientNetworkManagers[0]); |
ShadauxCat
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bringing #1543 back from
experimental-developintodevelop