feat!: network variables - client auth, permission cleanup, containers - #1074
Merged
Conversation
mattwalsh-unity
commented
Aug 20, 2021
mattwalsh-unity
commented
Aug 24, 2021
mattwalsh-unity
changed the base branch from
feature/container_cleanup
to
develop
August 24, 2021 18:09
…ies/com.unity.multiplayer.mlapi into experimental/client_auth
…ies/com.unity.multiplayer.mlapi into experimental/client_auth
mattwalsh-unity
commented
Aug 24, 2021
| /// Constructs a new NetworkVariableSettings instance | ||
| /// </summary> | ||
| public NetworkVariableSettings() { } | ||
| public NetworkVariableReadPermission ReadPermission = NetworkVariableReadPermission.Everyone; |
Contributor
Author
There was a problem hiding this comment.
I'll remove this class in a separate commit, because at this point all it does is let you specify the read perms on the variable
mattwalsh-unity
changed the title
mattwalsh-unity
marked this pull request as ready for review
August 24, 2021 23:50
0xFA11
changed the title
0xFA11
reviewed
Aug 25, 2021
0xFA11
reviewed
Aug 25, 2021
0xFA11
reviewed
Aug 25, 2021
0xFA11
reviewed
Aug 25, 2021
0xFA11
approved these changes
Aug 25, 2021
0xFA11
left a comment
0xFA11
left a comment
Contributor
There was a problem hiding this comment.
we still have things to do after this PR but it's a good cleanup and a good step towards a better direction!
mattwalsh-unity
enabled auto-merge (squash)
August 25, 2021 17:52
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
Unity-Technologies#1074) * refactor!: convert NetworkTransform.NetworkState to `struct` * feat!: remove client network permissions [MTT-1019] * NetworkList is now a derived class * de-interface * removed valueRef * added host tests * updated NetworkVarBufferCopyTest * container cleanup * channel cleanup * fixed client perm, more perm tests * INetworkVariable -> NetworkVariableBase * remove NetworkVariableBase.SetNetworkBehaviour() * fix tools project tests Co-authored-by: M. Fatih MAR <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.