Extend Transport with address - #13
Conversation
|
hey @LukeStampfli — I'm seeing PR 512 merged into MLAPI repo already. |
This PR has been reverted 😢. Still waiting for someone to notice this lonely RFC. |
|
hmm, in this case, I wonder what @wackoisgod would think about this. (nothing but my 2 cents) Also, I think we could have alternatives but as you outlined in the RFC, we might want to have another interface just for non-IP:Port based connection credentials as per your example, Room & Region. |
|
So I agree with @MFatihMAR that we should likely make this a little more flexible because not everything could be a simple ip and port for example Relay is not its actually a string join code. I could imagine maybe there is a transport that us using HTTP long poll or something that is just a url; So I agree that we should look at something that allows for users to define their own solution if need be or at least define some data that can be interpreted by the transport. With that said I would like to hold off on any changes to the transport right now until we can just look holistically how we want the transport to be in the future because I think there should be much broader changes in how we represent the transport and we could take into account connection data. |
|
I agree with what both of you said. I think we need to re-explore this at a later point in time and come up with a better solution. I'll close this RFC as it has been open for way too long already. |
See linked RFC document →
RFC for adding address and port properties to transport to make them more hot swappable.