Skip to content

refactor: Unified spawn handling - #703

Closed
Lutz89 wants to merge 47 commits into
Unity-Technologies:developfrom
Lutz89:spawnRefactoring
Closed

refactor: Unified spawn handling#703
Lutz89 wants to merge 47 commits into
Unity-Technologies:developfrom
Lutz89:spawnRefactoring

Conversation

@Lutz89

@Lutz89 Lutz89 commented Apr 5, 2021

Copy link
Copy Markdown

Writing and reading the spawn data is now centralized within the NetworkSpawnManager.

nezix and others added 30 commits August 28, 2020 13:47
Improve the example with an event listener
Added missing `transform`
Synchronize was missing an h! Hope this doesnt break any permalinks to this page?
Fixed typo in networkedvar.md
Documentation type miss MyServerRpc → MyServerRPC
Update object-visibility.md
…y_documentation

docs: Fix typos in readme and contributing
* docs: Remove Mirror from feature comparison

* docs: Remove blog from documentation website

* docs: Update documentation website footer.

* docs: Update git links on documentation website

* docs: Update website index
InvokeServerRpc(MyServerRpc, Random.Range(-50, 50)); "Rpc" should be written in capital letters otherwise an exception will be thrown
Added multiplayer forum button.
Fix github release links in readme.md
* docs: Update issue templates

- Updated labels of Feedback templates
- Added Other Issues, Support, Feedback and RFC Tracking Issue templates

* docs: Add issue template config
* Include instance ID in soft sync failure message

* Use explicit string format

Co-authored-by: Luke Stampfli <[email protected]>

Co-authored-by: Luke Stampfli <[email protected]>
Adds a "Hold on, heard the news?" section to the top of the readme which describes upcoming release for those users who discover the github after the keynote but before release.
…ires ownership (#627)

* add todo comments

* fix: implement warning logs on non-owner invoking ServerRpc that requires ownership
Removed old mlapi.network links to api/wiki/docs and replaced with nice shiny new Multiplayer docs site links.
* test: NetworkTickSystem test

* test: NetworkTickSystem test, removed unneeded code
…#629)

* fix: Fix object traversal assigning instanceIds to none scene objects

* comment added

Co-authored-by: Matt Walsh <[email protected]>
Jesse Olmer and others added 11 commits March 17, 2021 14:01
…icks (#640)

PerformanceDataManager reuses PerformanceTickData by resetting per-frame
Replaces deferred linq query in PerformanceTickData loop.
… clean import (#645)

* Add an dummy ILPP to force 2019.4 to proper compilation order

* Turning on this test for 2019.4

* Hack -> Workaround rename

Co-authored-by: Matt Walsh <[email protected]>
Co-authored-by: Matt Walsh <[email protected]>
Writing and reading the spawn data is now centralized within the NetworkSpawnManager.
@unity-cla-assistant

unity-cla-assistant commented Apr 5, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Lutz89 and others added 2 commits April 5, 2021 13:52
Writing and reading the spawn data is now centralized within the NetworkSpawnManager.
…nity.multiplayer.mlapi into spawnRefactoring

# Conflicts:
#	com.unity.multiplayer.mlapi/Runtime/Spawning/NetworkSpawnManager.cs

@Dodo2306 Dodo2306 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested and reviewed

@0xFA11

0xFA11 commented Apr 5, 2021

Copy link
Copy Markdown
Contributor

@NoelStephensUnity

@TwoTenPvP

Copy link
Copy Markdown
Contributor

PR makes total sense. However, lets not merge this before #696

Great contribution.

@TwoTenPvP
TwoTenPvP changed the base branch from master to develop April 6, 2021 09:00
@TwoTenPvP
TwoTenPvP changed the base branch from develop to master April 6, 2021 09:01
@TwoTenPvP

Copy link
Copy Markdown
Contributor

Please have this PR target develop. Once that is done I am happy with it. #696 is now in.

@Lutz89

Lutz89 commented Apr 6, 2021

Copy link
Copy Markdown
Author

Please have this PR target develop. Once that is done I am happy with it. #696 is now in.

Hey TwoTenPvP, do I have to change that? :)

@TwoTenPvP

Copy link
Copy Markdown
Contributor

Please have this PR target develop. Once that is done I am happy with it. #696 is now in.

Hey TwoTenPvP, do I have to change that? :)

Yes. Right now it targets master. No PR's will be accepted towards master.

@Lutz89
Lutz89 changed the base branch from master to develop April 6, 2021 15:25
@Lutz89

Lutz89 commented Apr 6, 2021

Copy link
Copy Markdown
Author

Please have this PR target develop. Once that is done I am happy with it. #696 is now in.

Hey TwoTenPvP, do I have to change that? :)

Yes. Right now it targets master. No PR's will be accepted towards master.

Okay, thank you! I have changed it to develop.

@TwoTenPvP

TwoTenPvP commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

Please have this PR target develop. Once that is done I am happy with it. #696 is now in.

Hey TwoTenPvP, do I have to change that? :)

Yes. Right now it targets master. No PR's will be accepted towards master.

Okay, thank you! I have changed it to develop.

Right, but the branch is not based on develop. I would suggest either rebasing your commit to develop branch or manually create a new branch based on develop and copy paste your changes there. Then submit a new PR.

@Lutz89

Lutz89 commented Apr 7, 2021

Copy link
Copy Markdown
Author

Closed. I will redo the changes within a new develop branch

@Lutz89 Lutz89 closed this Apr 7, 2021
@Lutz89
Lutz89 deleted the spawnRefactoring branch April 7, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.