Skip to content

Enable mixed call stacks when debuggee loads a mono-2.0* dynamic libr…#7

Merged
mderoy merged 1 commit into
Unity-Technologies:masterfrom
joncham:non-env-var-enable
Jan 22, 2018
Merged

Enable mixed call stacks when debuggee loads a mono-2.0* dynamic libr…#7
mderoy merged 1 commit into
Unity-Technologies:masterfrom
joncham:non-env-var-enable

Conversation

@joncham

@joncham joncham commented Jan 5, 2018

Copy link
Copy Markdown
Member

…ary into the process. We still only process if a file exists on disk with the same process id. Also, enable mixed call stacks for non-main threads.

…ary into the process. We still only process if a file exists on disk with the same process id. Also, enable mixed call stacks for non-main threads.
@joncham joncham requested a review from mderoy January 5, 2018 18:15
private static FileStream _fileStream;
private static StreamReader _fileStreamReader;

public void OnLoadComplete(DkmProcess process, DkmWorkList workList, DkmEventDescriptor eventDescriptor)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future Cleanup: We could probably remove this window stuff, unless we're planning on logging things to the output window.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but I see we log other info there as well.

@mderoy mderoy merged commit 4606aab into Unity-Technologies:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants