Embed function#235
Merged
jordansread merged 11 commits intoUSGS-R:embed-functionfrom Sep 10, 2015
Merged
Conversation
added 8 commits
September 9, 2015 16:09
Merge branch 'embed-function' of github.com:jread-usgs/gsplot into embed-function # Conflicts: # R/points.R
Contributor
|
cool |
|
👍 much more intuitive than having to also say |
Member
|
This makes me happy! |
Member
Author
|
note that this currently doesn't support multiple embedded functions, but I see several use cases for that: gs <- lines(gsplot(), c(0,3), c(2,4), callouts(labels=c('dogs','cats'),col='yellow'), error_bar(x.low=c(NA,1)))upvote if you want this? |
Contributor
|
👍 it will likely be non-intuitive and hard to deal with error if users can't do two embedded calls. Also, we may want some fanciness in the future that would make this use case more common. |
Member
|
👍 Upvoting. I don't have time today for a review, but if you feel like merging, I can live with discovering issues as we go (on this!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anyone interested can take a look:
and callouts too