Add noResolvePaths option#1139
Merged
Merged
Conversation
tomblind
approved these changes
Sep 20, 2021
sanikoyes
pushed a commit
to sanikoyes/TypeScriptToLua
that referenced
this pull request
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding #1101 and #1118
It could happen that someone is importing lua sources that internally require some environment-provided library. It would then be impossible to mark these as @NoResolution in .d.ts files. Therefore I have added a
noResolvePathsoption (I'm open for other names) to our tsconfig that act as a global list of lua require paths.For example tsconfig.json:
{ "compilerOptions": { // .... }, "tstl": { "noResolvePaths": ["foo.bar", "baz"] } }Will cause the following requires to not throw a resolution error. They will also not be rewritten:
Currently this IS case-sensitive.