close TrinityCore#19845

…d fix a related crash

Closes TrinityCore#19853

Core/Collision: Fixed MOPY chunk flags enum.

Also avoid loading destructible WMOs into vmaps.

VMap re-extraction is required.

Closes TrinityCore#15798.

Closes TrinityCore#19810 by ForesterDev

…ly. This fixes the incorrect message ("Absorb" instead of "Evade"), and also removes the root cause of the original evade follow bug (that was prevented in 1945874).

…gering themselves even with cooldown set).

…port

Closes TrinityCore#14672

…rmal click)

Closes TrinityCore#19819

* Pet/Guardian AI hook re-organizing:
- Adjust OwnerAttacked/OwnerAttackedBy hooks on CreatureAI to fire for all owned units, not just player pets. This should allow guardians to more reliably recognize valid targets.
- Kill off the AttackedBy hook. While it was defined in CreatureAI.h as virtual, it was only ever invoked for player pets in specific situations. This makes it classic developer bait.
  - Adjust PetAI to use DamageTaken instead of AttackedBy.
  - Adjust behavior of AttackStart on PetAI to compensate.

…yCore#19840)

* Add new method Map::getFullVMapDataForPosition to get area info and liquid info in a single vmap lookup
* Use this lookup in Map:: relocation methods to update m_areaId and m_zoneId fields on WorldObject
* Adjust GetZoneId/GetAreaId on WorldObject to always return these cached fields
* Clean up liquid state handling on Unit and Player
* Hand floor's Z coord up through GetFullTerrainStatusForPosition, use it to update a new field in WorldObject, and use that to feed a new GetFloorZ call on WorldObject.

Closes TrinityCore#16489

Correct the correct text before Cataclysme
3.3.5 only

- This would incur in a crash after attempting to convert the Corpse object into Player

Closes TrinityCore#19227
Closes TrinityCore#19862

Partially revert 753e707 and 12c680f to simplify the code and to only remove GMs from the target list.

… DB modification commands (npc move and npc delete), which are horrible and should be deleted anyway.

Fixes TrinityCore#20104.

…k for name validation

Closes TrinityCore#20094

…wn groups based on boss state. (TrinityCore#20103)

…yxia's Lair, Eye of Eternity.

…ityCore#20110)

Partial revert of of 6c21ddd.
Closes TrinityCore#16211.

Fixed the following typos:
- 'Clues in the Thicket' (9971) RewardText typo (Is it was/Is it what)
- `An Unseen Hand` (10013) RewardText typo (duplicated words "it to me")
- 'Evil Draws Near' (10923) Progress typo (ben/been)

…wardText

- Previous content: 103 characters. Added content: 163 characters. Full text: 266 characters.
- RewardText completion source: sql/old/4.3.4/TDB0_to_TDB1_updates/world/012_quest_template.sql

…remain in DB (TrinityCore#20112)

http://www.wowhead.com/quest=10232/in-a-scrap-with-the-legion

- Another quest_offer_reward.RewardText cut short, missing ≈ 60% of its content.
- Previous content: 137 characters. Added content: 193 characters. Full text: 330 characters.
- RewardText content source (besides verifying the actual content on wowhead.com):

https://github.com/TrinityCore/TrinityCore/blob/master/sql/old/4.3.4/TDB0_to_TDB1_updates/world/012_quest_template.sql

http://www.wowhead.com/quest=10203/invaluable-asset-zapping

- Another quest_offer_reward.RewardText cut short, missing ≈33% of its content.
- Previous: 290 characters. Added: 143 characters. Full text: 433 characters.

http://www.wowhead.com/quest=10335/surveying-the-ruins

- Another quest_offer_reward.RewardText cut short, missing half of its content.
- Previous: 114 characters. Added: 115 characters. Full text: 229 characters.

http://www.wowhead.com/quest=10721/a-boaring-time-for-grulloc
https://wow.gamepedia.com/Quest:A_Boaring_Time_for_Grulloc

- Quest 10721 showed up in-game with the same Reward Text as Quest Description
- quest_template.QuestDescription was inserted as quest_offer_reward.RewardText
- issue also found in https://github.com/dalaranwow/dalaran-wow/issues/1926
- Correct RewardText is based on content from the 3 linked pages above.

…ed existed.

- Rename JustRespawned to JustAppeared, which better matches its behavior anyway.
- Properly invoke JustAppeared for new (re-)spawns - fixes TrinityCore#20111.
- Fix Thaddius script to work with dynamic_spawning (mostly unrelated to the above) - Feugen/Stalagg should really be a summon group, but I don't have time to fix that right now.
- Fix default value for DynamicEscortNPC to match worldserver.conf.dist.

http://www.wowhead.com/quest=10248/you-robot

- Progress text (quest_request_items) was missing completely (request item: Scrap Reaver X6000 Controller)
- Reward Text (quest_offer_reward.RewardText) had lost '-52 Nether-Rocket from certain doom!' from the end.

#MakeUlduarGreatAgain

This reverts commit 21b03e7.

Closes TrinityCore#19910

Closes TrinityCore#20113
By Nertx

- Fixed Shadow Trap and Defile Targets
- Fixed Shadow Trap Summon Delay and Duration
- Fixed Berserk Timer (15 Minutes)
- Fixed Shadow Trap Despawn when Snowstorm starts

…(current active) movement generator