Skip to content

Various quest fixes1#4553

Closed
nelegalno wants to merge 14 commits into
TrinityCore:masterfrom
nelegalno:fixes1
Closed

Various quest fixes1#4553
nelegalno wants to merge 14 commits into
TrinityCore:masterfrom
nelegalno:fixes1

Conversation

@nelegalno

Copy link
Copy Markdown
Contributor

Brother Keltan position workaround until someone can sniff the correct start location and path he moves on. Doesn't close #1964 (Aokromes provided sniff for the waypoints)
Grim(oire) Business quest workaround. Closes #3078
Ogre Heaven fix PrevQuestID by shlomi1515. Closes #2732
Add conditions to Slaves to Saronite for Horde version 10z to Discover- for the quest fix ( #2898 ). Closes #4378
Remove SmartAI from Tiger Matriarch Credit NPC because it have no SAI script
Fix Report to Gryan Stoutmantle creature_questrelation values. Closes #4461
Wildlord Antelarion NPC gossip fix. Closes #4444
Drowned Guardian & Phylactery Guardian summoned NPC should not give XP fix by tobmaps. Closes #1860
Add The Botanica and The Mecanar exits (not from sniff) by Discover-. Closes #3369
Emergency Supplies quest fix by nelegalno. Closes #4187
Finding the Keymaster event_scripts fix by nelegalno. Closes #2604
Glyph Chasing quest workaround by unknown autor (updated by maxxx). Closes #1682
Peace at Last quest fix by gecko32. Closes #3144
The Thunderspike quest fix. replacement for the not working dbcccbb
Update some place holders in npc_text by malcrom. Closes #4545
Some Missing Gossip by malcrom. Closes #4521
Some Storm Peaks Gossip updates by malcrom. Closes #4519
Spawn & Pathing for Horace Alder Entry: 27704 "Not Spawned" by malcrom. Closes #4272
Some Hunterlands fixups by malcrom. Closes #4274
Pathing for King Dred Entry: 27483 "Drak'Tharon Keep" by malcrom. Closes #4423
Missing Scholazar Basin gossip by malcrom. Closes #4315
Pathing for Foreman Tionn Entry: 24006 "4XX Path" by malcrom. Closes #4288

…t start location and path he moves on by nelegalno. Closes #1964

Grim(oire) Business quest workaround.
Ogre Heaven fix PrevQuestID by shlomi1515. Closes #2732
Add conditions to Slaves to Saronite for Horde version 10z to Discover- for the quest fix ( #2898 ). Closes #4378
Remove SmartAI from Tiger Matriarch Credit NPC because it have no SAI script
Fix Report to Gryan Stoutmantle creature_questrelation values. Closes #4461
Wildlord Antelarion NPC gossip fix. Closes #4444
Drowned Guardian & Phylactery Guardian summoned NPC should not give XP fix by tobmaps. Closes #1860
Add The Botanica and The Mecanar exits (not from sniff) by Discover-. Closes #3369
Emergency Supplies quest fix by nelegalno. Closes #4187
Finding the Keymaster event_scripts fix by nelegalno. Closes #2604
Glyph Chasing quest workaround by unknown autor (updated by maxxx). Closes #1682
Peace at Last quest fix by gecko32. Closes #3144
The Thunderspike quest fix. replacement for the not working dbcccbb
@JasperAppec

Copy link
Copy Markdown

Much better. :)

@nelegalno

Copy link
Copy Markdown
Contributor Author

A bit of a rushed up job :(

@Pitcrawler

Copy link
Copy Markdown
Contributor

Please have a look at this #4187. Perhaps this one is even better than yours...

@ZxBiohazardZx

Copy link
Copy Markdown
Contributor

collection of fixes with unknown heritage and correctness, some of these fixes already got pushed

@nelegalno

Copy link
Copy Markdown
Contributor Author

@ZxBiohazardZx do show me one of the pushed fixes that is still in the pull request? After all it's not my fault that you decided to add them after I made the pull request. Not to mention that some of the ones you added need further work before they are ready.
And considering that some of the fixes that are being pushed here got no public screening for correctness, are obviously are not tested and aren't working at all I can't agree with your reason for closing my pull request.

P.S. From what I can see you also haven't bothered to even read/test them before adding, I on the other hand have tested, published and corrected each and every one before adding to the pull.

asido pushed a commit to asido/TrinityCore that referenced this pull request Mar 12, 2012
1) Fix Leeching Swarm damage and create spell difficulty links to code. Closes  issue TrinityCore#4909 .
2) Fix Valkyr's Touch. Closes  issue TrinityCore#4553 .
3) Fix Permafrost aura difficulty check.
4) Reduce Slime Pool damage range.
5) Avoid Shaman Champion Heroism spam using 5 minutes (CD) as timer.
6) Fix many spell target selection to only select players (no more totens or pets).
7) Fix Anub'arak Spike being able to receibe the permafrost aura in order to cast spike fail, hopefully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants