[DRAFT] Scripts/Scarlet Enclave: Gift Of The Harvester by Sorikoff · Pull Request #23114 · TrinityCore/TrinityCore

Sorikoff · 2019-03-14T16:48:45Z

Changes proposed:

Move spell Gift of the Harvester out from hacks to a SpellScript.
Implement GameObjectAI for item Gift of the Harvester (animation before cast), therefore dropping Data3 value (spell casted in this case).

Target branch(es): 3.3.5

Tests performed: Does build. Could work-in-game.

Known issues and TODO list: (add/remove lines as needed)

Crash happens when casting spell inside GameObjectAI because this (WorldObject*) becomes NULL-ed for some reason.
https://gist.github.com/Sorikoff/3d1ed6ee2e5573198fb99c8c1ebaf940

TrinityCore/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp

Line 904 in a1dec9b

me->CastSpell(nullptr, SPELL_GIFT_OF_THE_HARVESTER, true);
Neither ghoul nor ghost are summoned.

Keader · 2019-03-14T17:38:13Z

@@ -0,0 +1,3 @@
+INSERT INTO `spell_script_names` VALUES
+(52479, 'spell_gift_of_the_harvester');
+UPDATE `gameobject_template` SET `Data3`=0,`AIName`='',`ScriptName`='gift_of_the_harvesterAI' WHERE `entry`=190769;


why data3=0?

Because spell will be casted early, but animation is missing.

Animations are not implemented for al most all gobs type, better to keep the original value and wait for a generic solution.

Just as a footnote: Aokromes always used to tell me that gameobject_template.Data* are sniffed data and should not be changed.

Here the sequence used by the gob (and probably any trap) https://gist.github.com/Killyana/05753c48ad36b49905924f4ed1811cca
01:59:23 - the gob is summoned
01:59:24 - the spell 52479 is cast by the gob
01:59:24 - SMSG_GAMEOBJECT_CUSTOM_ANIM
01:59:26 - SMSG_GAMEOBJECT_DESPAWN_ANIM
01:59:26 - SMSG_DESTROY_OBJECT
We have already an issue #23109 about this.
So no need to change the data or use extra code to activate the gob animation.

-- Faction must be updated UPDATE `gameobject_template_addon` SET `faction`=1610 WHERE `entry`=190769;

Well, then I am going to revert gob changes (spell script is still welcome I believe).

Signed-off-by: Sorikoff <[email protected]>

ccrs · 2019-03-14T20:53:41Z

+
+    void HandleScriptEffect(SpellEffIndex /*effIndex*/)
+    {
+        uint32 spellId = urand(0, 1) ? SPELL_MINER_GHOUL_TRANSFORM : SPELL_MINER_GHOST_TRANSFORM;


use the random uint32 picker, not urand

btw why the hell is RAND inside CreatureAIImpl.h ??

You mean this fd64cb2?

No pratical change ._.

yep
@Keader the concept is: if there is a helper designed to do something, use it

jackpoz · 2019-03-15T11:29:59Z

Maybe set the PR as draft if it's not complete yet. You might want to include a crashlog in Debug mode too to let others see what's causing the crash

Keader · 2019-03-15T11:36:04Z

+        _scheduler.Schedule(2s, [this](TaskContext /*context*/)
+        {
+            me->SendCustomAnim(0);
+            me->CastSpell(nullptr, SPELL_GIFT_OF_THE_HARVESTER, true);


"me" cant be nullptr or schedule not even will be executed.
weird because 52479 Gift of the Harvester has conditions in DB, so implicit target need handle with this.
You debuged it already?

missing _scheduler.CancellAll on death/removefromworld maybe?

You think this might be the reason of crashes?

maybe it is needed? (before scheduler) should avoid crash (i think)

_scheduler.SetValidator([this] { return me != nullptr; });

Looks like when TaskSchedule is running, object is despawned already.
So, looks like 2 sec time is wrong, or object need more time before despawn.

It's not "me" being null, look at stack frame 17

me = caster
and caster is null at this point: https://gist.github.com/Sorikoff/3d1ed6ee2e5573198fb99c8c1ebaf940#file-gistfile1-txt-L17
So while this schedule is executing, object (me/caster) despawn.

Or objects still use a little trigger creature to cast spells?

#17 0x0000555557b81f42 in WorldObject::CastSpell (this=0x7fff82615c00, target=0x0, spellId=52479

"this" is "me" and it's not null

ok... but why caster is null in #2?
if i remember right, all objects use a world trigger to cast spells, idk if is current behavior still.

Maybe it's a bug when the caster is a gameobject

Keader · 2019-03-15T11:40:48Z

@Shauren Taskscheduler work like "assync basic events" right?
I mean, if owner of event become null, scheduled events can be executed?

Sorikoff · 2019-03-15T12:16:26Z

Debug results https://gist.github.com/Sorikoff/3d1ed6ee2e5573198fb99c8c1ebaf940.

ccrs · 2019-03-15T12:22:46Z

@Keader TaskScheduler can execute both synchronously and asynchronously, it depends which method is used to schedule the task
TaskScheduler::Async
TaskScheduler::Schedule

jackpoz · 2019-03-15T14:06:44Z

I mean, if owner of event become null, scheduled events can be executed?

this is 0x7fff82615c00 so it's not null. The null is deep down the callstack, probably some GetCaster() calls expecting the caster to still be there. Debugging it should show it.

Keader · 2019-03-15T14:53:02Z

EventMap can have same behavior?
i mean, can execute a event if event_owner is despawned/despawning?

ccrs · 2019-03-15T16:16:47Z

both, eventmap and taskscheduler rely on Unit::Update, if its not called, both do nothing.
IIRC dead creatures do NOT call Unit::Update

jackpoz · 2019-03-23T13:41:22Z

any followup on this @Sorikoff ? did you find the cause of the crash

Edit: check the comment at #23114 (comment)

Please set this PR as draft until all issues has been solved

jackpoz · 2019-03-23T13:49:03Z

+    void HandleScriptEffect(SpellEffIndex /*effIndex*/)
+    {
+        uint32 spellId = RAND(SPELL_MINER_GHOUL_TRANSFORM, SPELL_MINER_GHOST_TRANSFORM);
+        GetCaster()->CastSpell(GetHitUnit(), spellId, true);


GetCaster() returns Unit* so ofc it will return NULL when the caster is a GameObject

TrinityCore/src/server/game/Spells/SpellScript.h

Line 379 in a926a30

Unit* GetCaster() const;

Try GetGObjCaster() instead (and NULL check it too)

TrinityCore/src/server/game/Spells/SpellScript.h

Line 860 in a926a30

GameObject* GetGObjCaster() const;

After that set a breakpoint here and debug it to ensure everything works as expected

Works like a charm now. Thanks a lot!

Sorikoff · 2019-03-24T04:44:48Z

I will continue later on.

jackpoz · 2019-03-31T12:10:08Z

Hi, is this PR closed now ?

Sorikoff · 2019-03-31T13:58:03Z

Yep. More generic fixes are needed.

Sorikoff added 2 commits March 14, 2019 18:35

Gift Of The Harvester

2714168

Remove SQL

a1dec9b

Keader reviewed Mar 14, 2019

View reviewed changes

Comment thread src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp Outdated

Keader reviewed Mar 14, 2019

View reviewed changes

Comment thread src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp

Keader reviewed Mar 14, 2019

View reviewed changes

Comment thread src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp Outdated

Keader reviewed Mar 14, 2019

View reviewed changes

Comment thread sql/updates/world/3.3.5/9999_99_99_99_world.sql

Sorikoff added 2 commits March 14, 2019 20:31

Fixes

5b7abae

Signed-off-by: Sorikoff <[email protected]>

Fixes Continued

3791075

ccrs reviewed Mar 14, 2019

View reviewed changes

Sorikoff added 3 commits March 15, 2019 07:19

RAND

fd64cb2

Missing include

f8fc2e6

Wrong one

823df62

jackpoz added Feedback-FixOutdatedMissingWIP Branch-3.3.5a labels Mar 15, 2019

Keader reviewed Mar 15, 2019

View reviewed changes

jackpoz reviewed Mar 23, 2019

View reviewed changes

Sorikoff changed the title ~~Scripts/Scarlet Enclave: Gift Of The Harvester~~ [DRAFT] Scripts/Scarlet Enclave: Gift Of The Harvester Mar 24, 2019

Use GameObject

46d016b

Sorikoff closed this Mar 31, 2019

Aokromes removed Feedback-FixOutdatedMissingWIP labels Mar 31, 2019

Sorikoff deleted the 3.3.5-giftoftheharvester branch April 13, 2019 08:11

Conversation

Sorikoff commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Killyana Mar 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jackpoz commented Mar 15, 2019

Uh oh!

Keader Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Keader Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jackpoz Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Keader Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Keader commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sorikoff commented Mar 15, 2019

Uh oh!

ccrs commented Mar 15, 2019

Uh oh!

jackpoz commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Keader commented Mar 15, 2019

Uh oh!

ccrs commented Mar 15, 2019

Uh oh!

jackpoz commented Mar 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Sorikoff commented Mar 14, 2019 •

edited

Loading

Killyana Mar 30, 2019 •

edited

Loading

Keader Mar 15, 2019 •

edited

Loading

Keader Mar 15, 2019 •

edited

Loading

jackpoz Mar 15, 2019 •

edited

Loading

Keader Mar 15, 2019 •

edited

Loading

Keader commented Mar 15, 2019 •

edited

Loading

jackpoz commented Mar 15, 2019 •

edited

Loading

jackpoz commented Mar 23, 2019 •

edited

Loading