Core/Spells: Skip shapeshift removal while in Shadow Dance#22013
Closed
DanVS wants to merge 2 commits into
Closed
Conversation
kvipka
reviewed
Jun 13, 2018
| // remove other shapeshift before applying a new one | ||
| target->RemoveAurasByType(SPELL_AURA_MOD_SHAPESHIFT, ObjectGuid::Empty, GetBase()); | ||
| // skip on rogue shadow dance | ||
| if (!target->HasAura(51713)) |
Contributor
There was a problem hiding this comment.
if (target->getClass() != CLASS_ROGUE)
Contributor
|
hack, maybe use a spellscript for shadow dance? |
Contributor
Author
|
ccrs, which method should I use in such case? |
Contributor
|
its complicated, not an expert in spell system, but, since what you want is to prevent a default behaviour in one handler, logic tells to use a spellscript to override it and define what you want to happen. though, again, I dont know without actually digging into it if its even something appropiate for this issue. |
Contributor
Author
|
Will rework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Shadow Dance (51713) is a shapeshift effect. It means that applying Stealth or Vanish cancels Shadow Dance prematurely.
PR allows to skip shapeshifts removal while rogue is in Shadow Dance state.
Target branch(es):
Tests performed: Does build and works in-game.