Scripts/ICC: Minor Fixes for Lich King#20120
Conversation
|
Necrotic Plague should NOT target tanks. Though, it can jump unto the tank, but in order to cast Necrotic Plague, there must be a secondary target. EDIT: It must have a secondary target. If you want proof, go on youtube and search "been waiting for a long time for this achievement solo". |
ghost
added
Comp-C++Script
Comp-Core
Feedback-FixOutdatedMissingWIP
Sub-Instances
Sub-Spells
labels
|
Grimton1337 he dont changed necrotic plague... Demonid, changing place of Shadow Trap despawn, realy change something? |
|
@Keader The Necrotic Plague stuff was on Todo List, but was removed after checking some videos + his comment. The Shadow Trap Despawn change makes the despawn at the exact moment it does on retail, as soon as the snowstorm starts, right now is way before or way after i don't actually remember but you can test it out if you want. |
|
Ok, this is all im gonna add to this PR. @sirikfoll I want to talk to you about a second PR to make the encounter even more Blizzlike. |
|
This delay stuff can be checked in retail, i will try sniff it before travel today. |
|
@Keader case 73540 is easy to verify. On minute 4:10, the first Shadow Trap is Fully Activated: https://youtu.be/V0NNgcC--RY?t=4m10s On minute 5:10 you can see the first Shadow Trap despawn: https://youtu.be/V0NNgcC--RY?t=5m8s So i don't think anymore is needed for this to be verified, also, on retail you never see more than 4 Shadow Traps at the same time, right now on TC you can have up to 5 activated. About the Valkyr stuff, i just tested on a Clean TC: Valkyr just stay passive until a second target is found: |
|
Hmm, looks correct to me :) |
| { | ||
| me->GetMap()->SetZoneOverrideLight(AREA_ICECROWN_CITADEL, LIGHT_SNOWSTORM, 5000); | ||
| me->GetMap()->SetZoneWeather(AREA_ICECROWN_CITADEL, WEATHER_STATE_LIGHT_SNOW, 0.5f); | ||
| summons.DespawnEntry(NPC_SHADOW_TRAP); |
There was a problem hiding this comment.
@Demonid SpellHitTarget is called when spell hit a target right?
So it will call Despawn Shadow Trap alot of times no? (same to maps modifications)
There was a problem hiding this comment.
I believe it will only be called 2 times, one time for each Remorless Winter since the despawn is under a if:
if (spell->Id == REMORSELESS_WINTER_1 || spell->Id == REMORSELESS_WINTER_2)
There was a problem hiding this comment.
Naah, you are correct.
Both spells is self cast with SPELL_AURA_PERIODIC_TRIGGER_SPELL effect
It will hit only Lich King, so will be called 1 time per cast
There was a problem hiding this comment.
pls, you think that such a major failure would be present in the original script?
|
@Demonid PR is ready? can be merged? |
- Fixed Shadow Trap and Defile Targets - Fixed Shadow Trap Summon Delay and Duration - Fixed Berserk Timer (15 Minutes) - Fixed Shadow Trap Despawn when Snowstorm starts
Demonid
changed the title
|
@Keader Its ready if no issues are found. |
|
You dont need squash commits anymore, we can do it while merge :) |
- Fixed Shadow Trap and Defile Targets - Fixed Shadow Trap Summon Delay and Duration - Fixed Berserk Timer (15 Minutes) - Fixed Shadow Trap Despawn when Snowstorm starts (cherry picked from commit 9fa6885)
4 participants
Changes proposed:
I don't have Sniffs but everything on this PR can be check on this video:
https://www.youtube.com/watch?v=V0NNgcC--RY
Target branch(es):
3.3.5
master