[6.x] Core/Battlefield: Tol Barad#17124
Conversation
| @@ -0,0 +1,151 @@ | |||
| -- Tol Barad misc | |||
There was a problem hiding this comment.
we only use one file per database/commit
There was a problem hiding this comment.
Yeah I know, I will join them. Left it this way for others to make it more clear to see.
| UPDATE `creature_template` SET `gossip_menu_id` = 45069, `ScriptName` = 'npc_tb_spirit_guide' WHERE `entry` = 45075; | ||
| UPDATE `creature_template` SET `gossip_menu_id` = 45073, `ScriptName` = 'npc_tb_spirit_guide' WHERE `entry` = 45076; | ||
| UPDATE `creature_template` SET `gossip_menu_id` = 45072, `ScriptName` = 'npc_tb_spirit_guide' WHERE `entry` = 45077; | ||
| UPDATE `creature_template` SET `gossip_menu_id` = 45070, `ScriptName` = 'npc_tb_spirit_guide' WHERE `entry` = 45078; |
There was a problem hiding this comment.
This list of updates can be made 50% shorter in terms of line numbers, like this:
-- GRAVEYARDS --
-- Spirit Guides (45066 - 45079)
UPDATE `creature_template` SET `gossip_menu_id`= 45068, `ScriptName`= 'npc_tb_spirit_guide' WHERE `entry` IN (45068,45074);
UPDATE `creature_template` SET `gossip_menu_id`= 45069, `ScriptName`= 'npc_tb_spirit_guide' WHERE `entry` IN (45069,45075);
UPDATE `creature_template` SET `gossip_menu_id`= 45070, `ScriptName`= 'npc_tb_spirit_guide' WHERE `entry` IN (45070,45078);
UPDATE `creature_template` SET `gossip_menu_id`= 45071, `ScriptName`= 'npc_tb_spirit_guide' WHERE `entry` IN (45071,45079);
UPDATE `creature_template` SET `gossip_menu_id`= 45072, `ScriptName`= 'npc_tb_spirit_guide' WHERE `entry` IN (45072,45077);
UPDATE `creature_template` SET `gossip_menu_id`= 45073, `ScriptName`= 'npc_tb_spirit_guide' WHERE `entry` IN (45073,45076);(I haven't had time to check the rest of your SQL for redundancy yet)
|
This is complete? |
|
It's playable, but guide spirits aren't ressurecting... Probably has to be fixed separately in battlefield.cpp? |
|
Well, try wintergrasp, if spirit guides don't resurrect there, then it's a different bug of a different PR :P |
|
|
||
| -- Spawns are located half way down | ||
| SET @CGUID := 376000; -- 214 creature entries (380000->) | ||
| SET @OGUID := 68000; -- 111 gameobject entries |
There was a problem hiding this comment.
Note to merger, remember to check for unused guids over 250000 for creatures and 200000 for gameobjects.
There was a problem hiding this comment.
Based on TrinityCore rev. f663743 2016-06-18 16:23:55 +0200 (6.x branch), in TDB 6.04 plus updates up to and including 2016_06_17_01_world.sql, these values are available:
- 214 consecutive free GUIDs above 250000 in the
creaturetable: 250970 - 251183 - 111 consecutive free GUIDs above 200000 in the
gameobjecttable: 234355 - 234465
|
Not working in WG either. Spirit guides should probably ressurect just like in battlegrounds (automatically every 30 sec), right? |
|
Seems like has to be 16 (guid size) instead of 14 ?Not sure if this is the source of your issue. Commit 0fc728e |
|
@GitVerge: That size is only a hint, actual size can be different (it works like |
|
@DDuarte k, got it. Thanks |
|
|
||
| -- Spawns are located half way down | ||
| SET @CGUID := 250970; -- 214 creature entries | ||
| SET @OGUID := 234355; -- 111 gameobject entries |
There was a problem hiding this comment.
new range is need again :P compared with 4.3.4 db and found one commit missing on 6.x
There was a problem hiding this comment.
TrinityCore rev. 5f2c623 2016-06-20 21:53:53 +0200 (6.x branch) (Win64, Release, Static), TDB 6.04 plus updates up to and including 2016_06_20_02_world.sql. These values are available:
- 214 consecutive free GUIDs above 250000 in the
creaturetable: 250970 - 251183 - 111 consecutive free GUIDs above 200000 in the
gameobjecttable: 233475 - 233585
No new creatures added since previous check, 880 gameobject GUIDs removed or relocated.
|
@Shauren Since the remaining bug is part of a different commit this can be merged? |
5 participants
This is it. 🏁
Towers/spires cannot be destroyed because vehicle spells aren't supported yet.
Complete to-do list can be found in BattlefieldTB.cpp, line no. 18.