Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebookincubator/SocketRocket
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: Topface/SocketRocket
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 11 files changed
  • 4 contributors

Commits on May 27, 2014

  1. submodul's master branch

    DmIvanov committed May 27, 2014
    Configuration menu
    Copy the full SHA
    f240e29 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2014

  1. Configuration menu
    Copy the full SHA
    fb4c285 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2014

  1. Configuration menu
    Copy the full SHA
    86c0499 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2015

  1. Configuration menu
    Copy the full SHA
    2724dd4 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2017

  1. Fixes a typo

    feosuna1 committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    28264c0 View commit details
    Browse the repository at this point in the history
  2. Avoid using self as key for dispatch_set_specific

    I know that the documentation for `dispatch_queue_set_specific` says that keys are only compared as pointers, but using `self` as the key causes Xcode 8’s memory debugger to show `dispatch_set_specific` is strongly retaining self.  I know its not the case, but it makes it hard to track down other memory retention issues.
    
    This commit changes the key from `self` to `_workQueue`.
    feosuna1 committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    e837b18 View commit details
    Browse the repository at this point in the history
  3. Don’t strongly retain self in timer

    Fixes #499. Make sure we don’t strongly retain to self while inside the timer.  Otherwise, its possible that the socket has been disconnected, the owner no longer has a reference to the object, but the object still lives in memory so long as the timer exists.
    feosuna1 committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    2f80477 View commit details
    Browse the repository at this point in the history
  4. Close streams to a connecting ws that gets closed

    If you call `-open` then immediately `-close`, the `SRWebSocket` is marked as closed but:
    1) The delegate never gets called that the socket did close
    2) If `-openNetworkStreamWithCompletion:` ever invokes the completion block, the streams are left open
    3) The `SRWebSocket` instance never calls `_cleanupSelfReference` and the object is strongly retained.
    feosuna1 committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    5869d8b View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. Merge branch 'master' of https://github.com/kervich/SocketRocket

    Andrey Yurkevich committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    b3a3d39 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from kervich/master

    Fetch updates from vendor
    kervich authored Mar 13, 2018
    Configuration menu
    Copy the full SHA
    e44c67e View commit details
    Browse the repository at this point in the history
  3. Local updates (fine-tuning)

    Andrey Yurkevich committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    7699994 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. Merge pull request #2 from kervich/master

    Local updates (fine-tuning)
    kervich authored Mar 14, 2018
    Configuration menu
    Copy the full SHA
    8ae2e21 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. Merge pull request #5 from vladimir-uvarov/fix-memory-leaks

    Fix memory leaks
    kervich authored Mar 15, 2018
    Configuration menu
    Copy the full SHA
    ee7290b View commit details
    Browse the repository at this point in the history
  2. Updated podspec, removed pages

    Andrey Yurkevich committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    b49afbf View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. Merge pull request #6 from kervich/master

    0.5.1.2
    kervich authored Mar 16, 2018
    Configuration menu
    Copy the full SHA
    a948696 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2018

  1. Update xctoolchain submodule

    kervich committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    7d4342b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aab76bd View commit details
    Browse the repository at this point in the history
Loading