-
Notifications
You must be signed in to change notification settings - Fork 2k
Comparing changes
Open a pull request
base repository: facebookincubator/SocketRocket
base: main
head repository: Topface/SocketRocket
compare: master
- 17 commits
- 11 files changed
- 4 contributors
Commits on May 27, 2014
-
Configuration menu - View commit details
-
Copy full SHA for f240e29 - Browse repository at this point
Copy the full SHA f240e29View commit details
Commits on Jun 25, 2014
-
Configuration menu - View commit details
-
Copy full SHA for fb4c285 - Browse repository at this point
Copy the full SHA fb4c285View commit details
Commits on Oct 13, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 86c0499 - Browse repository at this point
Copy the full SHA 86c0499View commit details
Commits on May 14, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 2724dd4 - Browse repository at this point
Copy the full SHA 2724dd4View commit details
Commits on Feb 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 28264c0 - Browse repository at this point
Copy the full SHA 28264c0View commit details -
Avoid using self as key for dispatch_set_specific
I know that the documentation for `dispatch_queue_set_specific` says that keys are only compared as pointers, but using `self` as the key causes Xcode 8’s memory debugger to show `dispatch_set_specific` is strongly retaining self. I know its not the case, but it makes it hard to track down other memory retention issues. This commit changes the key from `self` to `_workQueue`.
Configuration menu - View commit details
-
Copy full SHA for e837b18 - Browse repository at this point
Copy the full SHA e837b18View commit details -
Don’t strongly retain self in timer
Fixes #499. Make sure we don’t strongly retain to self while inside the timer. Otherwise, its possible that the socket has been disconnected, the owner no longer has a reference to the object, but the object still lives in memory so long as the timer exists.
Configuration menu - View commit details
-
Copy full SHA for 2f80477 - Browse repository at this point
Copy the full SHA 2f80477View commit details -
Close streams to a connecting ws that gets closed
If you call `-open` then immediately `-close`, the `SRWebSocket` is marked as closed but: 1) The delegate never gets called that the socket did close 2) If `-openNetworkStreamWithCompletion:` ever invokes the completion block, the streams are left open 3) The `SRWebSocket` instance never calls `_cleanupSelfReference` and the object is strongly retained.
Configuration menu - View commit details
-
Copy full SHA for 5869d8b - Browse repository at this point
Copy the full SHA 5869d8bView commit details
Commits on Mar 13, 2018
-
Merge branch 'master' of https://github.com/kervich/SocketRocket
Andrey Yurkevich committedMar 13, 2018 Configuration menu - View commit details
-
Copy full SHA for b3a3d39 - Browse repository at this point
Copy the full SHA b3a3d39View commit details -
Configuration menu - View commit details
-
Copy full SHA for e44c67e - Browse repository at this point
Copy the full SHA e44c67eView commit details -
Andrey Yurkevich committed
Mar 13, 2018 Configuration menu - View commit details
-
Copy full SHA for 7699994 - Browse repository at this point
Copy the full SHA 7699994View commit details
Commits on Mar 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 8ae2e21 - Browse repository at this point
Copy the full SHA 8ae2e21View commit details
Commits on Mar 15, 2018
-
Merge pull request #5 from vladimir-uvarov/fix-memory-leaks
Fix memory leaks
Configuration menu - View commit details
-
Copy full SHA for ee7290b - Browse repository at this point
Copy the full SHA ee7290bView commit details -
Updated podspec, removed pages
Andrey Yurkevich committedMar 15, 2018 Configuration menu - View commit details
-
Copy full SHA for b49afbf - Browse repository at this point
Copy the full SHA b49afbfView commit details
Commits on Mar 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a948696 - Browse repository at this point
Copy the full SHA a948696View commit details
Commits on Mar 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7d4342b - Browse repository at this point
Copy the full SHA 7d4342bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aab76bd - Browse repository at this point
Copy the full SHA aab76bdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...master