Sender will fail to upload file artifact if it changes between creation and sending #870

Description of Bug

When creating an Artifact via run.save_file(), the checksum is calculated and stored in the artifact JSON in the cache, along with the path to the file. If that file is then changed between the time when it was asked to be saved by the user, and when it is actually sent by the sender(), the checksum will no longer match the file, and so the upload will fail. You'll get back an error like:

E       RuntimeError: uploading artifact 'test_file_artifact_6c49f901' to object storage failed for url '[https://simvue-ci.s3.amazonaws.com/'](https://simvue-ci.s3.amazonaws.com/%27) with status 400: <?xml version="1.0" encoding="UTF-8"?>
E       <Error><Code>BadDigest</Code><Message>The SHA256 you specified did not match the calculated checksum.</Message></Error>

Steps To Reproduce

Steps to reproduce the behavior:

1. Create a run in offline mode
2. Create a file
3. Do run.save_file()
4. Change the contents of the file
5. Run sender()

Expected behavior

The file should be uploaded (I guess as it was when the user called save_file()

Actual Behaviour

Error due to mismatched checksum

Setup

• OS: Ubuntu 22.04
• Python version 3.10