Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: s3tools/s3cmd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Threadless/s3cmd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jun 6, 2014

  1. Don't treat ValueErrors as a condition for retry 

    When using s3cmd sync, I would often encounter the following situation:

    WARNING: Retrying failed request: ************ (need more than 1 value to unpack)
    WARNING: Waiting 3 sec...
    ************ -> <fdopen>  [10 of 417]
     0 of 0     0% in    0s     0.00 B/s  failed
    WARNING: Retrying failed request: ************ (need more than 1 value to unpack)
    WARNING: Waiting 6 sec...
    ************ -> <fdopen>  [10 of 417]
     0 of 0     0% in    0s     0.00 B/s  failed
    WARNING: Retrying failed request: ************ (need more than 1 value to unpack)

Clearly this will continue to fail due to a programming error, so this
commit makes s3cmd fail hard.  A more encompassing exception class
(perhaps even StandardError) might be more appropriate, but I figured
this would be a good start.
    Rob Hoelz
    Rob Hoelz committed Jun 6, 2014
    Configuration menu
    Copy the full SHA
    b900e00 View commit details
    Browse the repository at this point in the history

  2. URL decode attributes header 

    The x-amz-meta-s3cmd-attrs header seems to have been changed so that
it contains URL-encoded text
    Rob Hoelz
    Rob Hoelz committed Jun 6, 2014
    Configuration menu
    Copy the full SHA
    f5bbb0d View commit details
    Browse the repository at this point in the history
Loading