test: count the probes that miss before the streaming cache hit - #44
Merged
Merged
Conversation
The test polls until a request comes back X-Cache: HIT. A probe sent before the first stream's tail has written the cache is itself a MISS and calls the upstream, so asserting exactly one upstream call failed whenever the write lost that race. Each MISS now accounts for one call; the HIT still has to make none. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
streaming_cache_hit_replays_assembled_ssepolls until a request comes backX-Cache: HIT. A probe sent before the first stream's post-flight task has written the cache is itself a MISS and calls the upstream, so the "exactly one upstream call" assertion failed whenever that write lost the race (seen locally once in a full run). Each MISS now accounts for one upstream call; the HIT still has to make none, which is what the test is about.Local: full integration suite green on own containers.
🤖 Generated with Claude Code