Add starting point for cross-browser tests within end-to-end tests#4560
Merged
kschiffer merged 1 commit intoTheThingsNetwork:v3.14from Sep 6, 2021
Merged
Conversation
adriansmares
approved these changes
Aug 26, 2021
bafonins
approved these changes
Sep 3, 2021
3002804 to
139f464
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This quickfix PR will add a starting point for cross-browser testing as part of our end-to-end test workflow.
Changes
job's that run the end-to-end tests, and to avoid having to cache go modulesjobthat runs the smoke tests on Firefox 78 (ESR)Testing
Tested this on my private fork.
Notes for Reviewers
The smoke tests on firefox will currently fail until #4559 is merged.
I think the old Firefox 78 is a good testing choice since it is preinstalled on many Ubuntu distributions. Cypress currently supports testing on chromium-based browsers, as well as Firefox. I don't think it is worth testing on any other chromium-based browser, since it effectively runs like Chrome itself. For now, we can hope that Cypress will support Safari and IE in the future and additionally do some manual testing on staging on these browsers.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.