Skip to content

Add starting point for cross-browser tests within end-to-end tests#4560

Merged
kschiffer merged 1 commit intoTheThingsNetwork:v3.14from
kschiffer:fix/e2e-cross-browser
Sep 6, 2021
Merged

Add starting point for cross-browser tests within end-to-end tests#4560
kschiffer merged 1 commit intoTheThingsNetwork:v3.14from
kschiffer:fix/e2e-cross-browser

Conversation

@kschiffer
Copy link
Copy Markdown
Contributor

Summary

This quickfix PR will add a starting point for cross-browser testing as part of our end-to-end test workflow.

Changes

  • Change workflow logic to pass build files using artifacts instead of (verbose) repeated caching
  • Use a build of the stack rather than running the stack on go to avoid setting up go in job's that run the end-to-end tests, and to avoid having to cache go modules
  • Add a job that runs the smoke tests on Firefox 78 (ESR)

Testing

Tested this on my private fork.

Notes for Reviewers

The smoke tests on firefox will currently fail until #4559 is merged.

I think the old Firefox 78 is a good testing choice since it is preinstalled on many Ubuntu distributions. Cypress currently supports testing on chromium-based browsers, as well as Firefox. I don't think it is worth testing on any other chromium-based browser, since it effectively runs like Chrome itself. For now, we can hope that Cypress will support Safari and IE in the future and additionally do some manual testing on staging on these browsers.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added the tooling Development tooling label Aug 25, 2021
@kschiffer kschiffer added this to the v3.14.2 milestone Aug 25, 2021
@kschiffer kschiffer requested a review from bafonins August 25, 2021 14:55
@kschiffer kschiffer self-assigned this Aug 25, 2021
@KrishnaIyer KrishnaIyer modified the milestones: v3.14.2, v3.15.0 Aug 26, 2021
@kschiffer kschiffer force-pushed the fix/e2e-cross-browser branch from 3002804 to 139f464 Compare September 6, 2021 08:25
@kschiffer kschiffer merged commit 4a723b0 into TheThingsNetwork:v3.14 Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling Development tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants