Skip to content

Fix concurrency of polyfill loads#4559

Merged
kschiffer merged 1 commit intov3.14from
fix/intl-polyfill-concurrency
Aug 31, 2021
Merged

Fix concurrency of polyfill loads#4559
kschiffer merged 1 commit intov3.14from
fix/intl-polyfill-concurrency

Conversation

@kschiffer
Copy link
Copy Markdown
Contributor

Summary

This quickfix PR fixes occasional crashes in the Console, when Intl polyfills are loaded.

Changes

  • Respect proper load order of polyfill imports
  • Add more polyfills

Testing

Manual testing using FF ESR, as well as on latest chrome via deleting the Intl API, e.g.

delete window.Intl.Locale

Notes for Reviewers

This would cause occasional crashes whenever the base polyfills were loaded in the wrong order, due to Promise.all() launching all requests concurrently.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added bug Something isn't working c/console This is related to the Console size/small This should not be a lot of work ui/web This is related to a web interface labels Aug 25, 2021
@kschiffer kschiffer added this to the v3.14.2 milestone Aug 25, 2021
@kschiffer kschiffer requested a review from bafonins August 25, 2021 14:04
@kschiffer kschiffer self-assigned this Aug 25, 2021
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Aug 25, 2021
@kschiffer kschiffer changed the title console,account: Fix concurrency of polyfill loads Fix concurrency of polyfill loads Aug 27, 2021
@KrishnaIyer KrishnaIyer modified the milestones: v3.14.2, v3.15.0 Aug 27, 2021
@kschiffer kschiffer merged commit 658c8ce into v3.14 Aug 31, 2021
@kschiffer kschiffer deleted the fix/intl-polyfill-concurrency branch August 31, 2021 10:04
@adriansmares adriansmares mentioned this pull request Sep 17, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working c/console This is related to the Console dependencies Pull requests that update a dependency file size/small This should not be a lot of work ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants