Skip to content

Fix synchronization in scheduler#3794

Merged
johanstokking merged 4 commits intov3.11from
fix/3334-schedule-conflicts
Feb 15, 2021
Merged

Fix synchronization in scheduler#3794
johanstokking merged 4 commits intov3.11from
fix/3334-schedule-conflicts

Conversation

@johanstokking
Copy link
Copy Markdown
Member

Summary

Fix synchronization in scheduler

References #3334 (comment)

Changes

  • Put write locks as state is being modified in Schedule() and ScheduleAnytime()

Testing

Unit testing

Regressions

None

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added this to the February 2021 milestone Feb 12, 2021
@johanstokking johanstokking self-assigned this Feb 12, 2021
@github-actions github-actions Bot added c/gateway server This is related to the Gateway Server compat/db This could affect Database compatibility labels Feb 12, 2021
Copy link
Copy Markdown
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow how did we not do this before.
LGTM

@johanstokking johanstokking merged commit e56f7f7 into v3.11 Feb 15, 2021
@johanstokking johanstokking deleted the fix/3334-schedule-conflicts branch February 15, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/gateway server This is related to the Gateway Server compat/db This could affect Database compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants