Skip to content

Fix panic in DLChannelReq with rejected frequencies#3704

Merged
htdvisser merged 2 commits intoTheThingsNetwork:v3.10from
rvolosatovs:fix/dl-channel-req
Jan 25, 2021
Merged

Fix panic in DLChannelReq with rejected frequencies#3704
htdvisser merged 2 commits intoTheThingsNetwork:v3.10from
rvolosatovs:fix/dl-channel-req

Conversation

@rvolosatovs
Copy link
Copy Markdown
Contributor

Summary

Backport #3688

Changes

  • Fix panic in DLChannelReq with rejected frequencies

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs added bug Something isn't working c/network server This is related to the Network Server prio/high needs/backport Needs to be backported to previous versions that are maintained labels Jan 25, 2021
@rvolosatovs rvolosatovs added this to the January 2021 milestone Jan 25, 2021
@htdvisser htdvisser assigned htdvisser and unassigned johanstokking Jan 25, 2021
@htdvisser htdvisser merged commit d592cdc into TheThingsNetwork:v3.10 Jan 25, 2021
@rvolosatovs rvolosatovs deleted the fix/dl-channel-req branch January 25, 2021 16:47
@johanstokking
Copy link
Copy Markdown
Member

@rvolosatovs this is backported but not released. What do we do with this?

@rvolosatovs
Copy link
Copy Markdown
Contributor Author

rvolosatovs commented Feb 10, 2021

@rvolosatovs this is backported but not released. What do we do with this?

Can you clarify this statement? Since it's backported from 3.11, it should be present in both 3.10 and 3.11 minors, what else do we need to release?

@johanstokking
Copy link
Copy Markdown
Member

@rvolosatovs this is backported but not released. What do we do with this?

Can you clarify this statement?

It's not part of a 3.10 release. The last one here is 3.10.7, and these commits are merged after. So yes, it is backported, but that's it.

@rvolosatovs
Copy link
Copy Markdown
Contributor Author

rvolosatovs commented Feb 11, 2021

If we don't want 3.10 to panic, then we have to release 3.10.8 with this fix. I'd say this definitely deserves to be released, since once this happens for a device - no class A downlinks will go through anymore.

@johanstokking
Copy link
Copy Markdown
Member

We released 3.11.0 now, so that's ok.

But next time, please file a Release issue so we don't forget about releasing things that we backported.

@KrishnaIyer
Copy link
Copy Markdown
Member

This is already deployed in TTS v3.10.9. We can make a TTSOS release for completeness.

johanstokking added a commit that referenced this pull request Feb 15, 2021
@johanstokking johanstokking mentioned this pull request Feb 15, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working c/network server This is related to the Network Server needs/backport Needs to be backported to previous versions that are maintained

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants