Skip to content

Fix panic in DLChannelReq with rejected frequencies#3688

Merged
rvolosatovs merged 2 commits intoTheThingsNetwork:v3.11from
rvolosatovs:fix/dl-channel-req
Jan 20, 2021
Merged

Fix panic in DLChannelReq with rejected frequencies#3688
rvolosatovs merged 2 commits intoTheThingsNetwork:v3.11from
rvolosatovs:fix/dl-channel-req

Conversation

@rvolosatovs
Copy link
Copy Markdown
Contributor

@rvolosatovs rvolosatovs commented Jan 20, 2021

Summary

Closes https://github.com/TheThingsIndustries/lorawan-stack/issues/2525

Changes

  • Fix panic in DLChannelReq with rejected frequencies

Testing

Unit tests

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs self-assigned this Jan 20, 2021
@rvolosatovs rvolosatovs added this to the January 2021 milestone Jan 20, 2021
@rvolosatovs rvolosatovs added bug Something isn't working c/network server This is related to the Network Server prio/high labels Jan 20, 2021
adriansmares
adriansmares approved these changes Jan 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@adriansmares adriansmares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rvolosatovs rvolosatovs merged commit a23fdc7 into TheThingsNetwork:v3.11 Jan 20, 2021
@rvolosatovs rvolosatovs deleted the fix/dl-channel-req branch January 20, 2021 18:10
@rvolosatovs rvolosatovs mentioned this pull request Jan 25, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johanstokking johanstokking Awaiting requested review from johanstokking

1 more reviewer

@adriansmares adriansmares adriansmares approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rvolosatovs rvolosatovs

Labels

bug Something isn't working c/network server This is related to the Network Server

Projects

None yet

Milestone

January 2021

Development

Successfully merging this pull request may close these issues.

2 participants

@rvolosatovs @adriansmares