Skip to content

Refactor NS metrics#2711

Merged
rvolosatovs merged 1 commit intoTheThingsNetwork:masterfrom
rvolosatovs:fix/ns-metrics
Jun 11, 2020
Merged

Refactor NS metrics#2711
rvolosatovs merged 1 commit intoTheThingsNetwork:masterfrom
rvolosatovs:fix/ns-metrics

Conversation

@rvolosatovs
Copy link
Copy Markdown
Contributor

Summary

Refactor NS metrics

Changes

  • Remove unique uplink metric
  • Add deduplicated uplink metric
  • Add processed uplink metric

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md. The target branch is set to master if the changes are fully compatible with existing API, database, configuration and CLI.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs added c/network server This is related to the Network Server blocking release This is blocking a release quickfix labels Jun 11, 2020
@rvolosatovs rvolosatovs added this to the June 2020 milestone Jun 11, 2020
@rvolosatovs rvolosatovs requested a review from htdvisser June 11, 2020 12:55
@rvolosatovs rvolosatovs self-assigned this Jun 11, 2020
- Remove `uplink_unique_total`
- Introduce `uplink_duplicates_total`
- Introduce `uplink_processed_total`
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 11, 2020

Coverage Status

Coverage decreased (-0.08%) to 73.159% when pulling cc04928 on rvolosatovs:fix/ns-metrics into 09282b6 on TheThingsNetwork:master.

Copy link
Copy Markdown
Contributor

@htdvisser htdvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvolosatovs rvolosatovs merged commit cfdcac3 into TheThingsNetwork:master Jun 11, 2020
@rvolosatovs rvolosatovs deleted the fix/ns-metrics branch June 11, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocking release This is blocking a release c/network server This is related to the Network Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants