Skip to content

Allow and use frames carrying FOpts with no FPort#2465

Merged
rvolosatovs merged 4 commits intoTheThingsNetwork:developfrom
rvolosatovs:fix/fopts
May 1, 2020
Merged

Allow and use frames carrying FOpts with no FPort#2465
rvolosatovs merged 4 commits intoTheThingsNetwork:developfrom
rvolosatovs:fix/fopts

Conversation

@rvolosatovs
Copy link
Copy Markdown
Contributor

Summary

Allow and use frames carrying FOpts with no FPort
Close #2455

Changes

  • For frames carrying only MAC commands, Network Server now attempts to fit them in FOpts omitting FPort, if possible, and sends them in FRMPayload with FPort 0 as usual otherwise.
  • Network Server now properly handles FPort 0 data uplinks carrying FOpts.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md. The target branch is set to master if the changes are fully compatible with existing API, database, configuration and CLI.
  • Testing: The changes are covered with unit tests. The changes are tested manually as well.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs added bug Something isn't working c/network server This is related to the Network Server blocking release This is blocking a release labels Apr 30, 2020
@rvolosatovs rvolosatovs added this to the April 2020 milestone Apr 30, 2020
@rvolosatovs rvolosatovs self-assigned this Apr 30, 2020
@htdvisser htdvisser modified the milestones: April 2020, May 2020 May 1, 2020
@rvolosatovs rvolosatovs merged commit 3947426 into TheThingsNetwork:develop May 1, 2020
@rvolosatovs rvolosatovs deleted the fix/fopts branch May 1, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocking release This is blocking a release bug Something isn't working c/network server This is related to the Network Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FPort==0 frames carrying FOpts must be allowed and properly handled

3 participants