Skip to content

Rename MAC and PHY fields in console#2451

Merged
pgalic96 merged 2 commits intomasterfrom
fix/2404-rename-dev-fields
May 8, 2020
Merged

Rename MAC and PHY fields in console#2451
pgalic96 merged 2 commits intomasterfrom
fix/2404-rename-dev-fields

Conversation

@pgalic96
Copy link
Copy Markdown
Contributor

Summary

Closes #2424

Changes

  • Change MAC version to LoRaWAN version and PHY version to Regional Parameters version

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md. The target branch is set to master if the changes are fully compatible with existing API, database, configuration and CLI.
  • Testing: The changes are covered with unit tests. The changes are tested manually as well.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@pgalic96 pgalic96 added c/console This is related to the Console quickfix labels Apr 29, 2020
@pgalic96 pgalic96 added this to the April 2020 milestone Apr 29, 2020
@pgalic96 pgalic96 self-assigned this Apr 29, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 29, 2020

Coverage Status

Coverage increased (+0.03%) to 73.154% when pulling 5d58f43 on fix/2404-rename-dev-fields into c637d93 on master.

Copy link
Copy Markdown
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the field description? @benolayinka can you make a proposal for rewording this as well?

image
(talking about the message under the field)

Also @pgalic96 please always post a screenshot for all frontend PRs with visual changes

Comment thread pkg/webui/lib/shared-messages.js
@htdvisser htdvisser modified the milestones: April 2020, May 2020 May 1, 2020
@pgalic96 pgalic96 force-pushed the fix/2404-rename-dev-fields branch 2 times, most recently from fa7ce79 to 2513220 Compare May 5, 2020 12:11
@pgalic96
Copy link
Copy Markdown
Contributor Author

pgalic96 commented May 5, 2020

@benolayinka can you think of something for #2451 (review) ?

@benolayinka
Copy link
Copy Markdown
Contributor

What about the field description? @benolayinka can you make a proposal for rewording this as well?

image
(talking about the message under the field)

Also @pgalic96 please always post a screenshot for all frontend PRs with visual changes

I'd say
The LoRaWAN version (MAC), as provided by the device manufacturer.
The Regional Parameters version (PHY), as provided by the device manufacturer.

All LoRaWAN devices are backwards compatible with the v2 defaults MAC_V1_0_2 and
MAC_PHY_V1_0_2_REV_B, right @johanstokking ? If so, it could be helpful to add that in the description as well

The LoRaWAN version (MAC), as provided by the device manufacturer. All LoRaWAN devices are backwards compatible with 1.0.2

or to add it as a note/default selection

MAC V1.0.2 (Compatible with all end devices)

@johanstokking
Copy link
Copy Markdown
Member

All LoRaWAN devices are backwards compatible with the v2 defaults MAC_V1_0_2 and
MAC_PHY_V1_0_2_REV_B, right @johanstokking ? If so, it could be helpful to add that in the description as well

No, we can't make this assumption about version compatibility.

@pgalic96 pgalic96 force-pushed the fix/2404-rename-dev-fields branch from 2513220 to 6fa22e6 Compare May 6, 2020 14:58
@pgalic96 pgalic96 requested a review from kschiffer May 6, 2020 14:59
@johanstokking
Copy link
Copy Markdown
Member

Please hold merge until #2488 is merged

@pgalic96 pgalic96 force-pushed the fix/2404-rename-dev-fields branch from 6fa22e6 to 5d58f43 Compare May 8, 2020 09:24
@pgalic96 pgalic96 merged commit e8ff5e3 into master May 8, 2020
@pgalic96 pgalic96 deleted the fix/2404-rename-dev-fields branch May 8, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c/console This is related to the Console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants