172 axios cleanup#288
Merged
jkwening merged 2 commits intoTheDevPath:developmentfrom Mar 25, 2018
Merged
Conversation
Replace remaining direct/hard coded backend request via axios with `makeRequest()` generic function from internal library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number:
#172 - post implementation clean up and refactor
Issue Description:
Replace remaining direct/hard coded backend request via axios with
makeRequest()generic function from internal library.Summary of solution:
makeRequest()from libraryserver-requests-utils.jsCan this issue be closed?
yes
Should any new issues be added as a result of this solution?
no
Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.
Thanks for contributing!