Skip to content

Fix matrix exponentiation type annotations - #15076

Open
Kanika0306 wants to merge 3 commits into
TheAlgorithms:masterfrom
Kanika0306:fix-matrix-exponentiation-type-annotations
Open

Fix matrix exponentiation type annotations#15076
Kanika0306 wants to merge 3 commits into
TheAlgorithms:masterfrom
Kanika0306:fix-matrix-exponentiation-type-annotations

Conversation

@Kanika0306

Copy link
Copy Markdown

Describe your change:

Fixes a NameError in Python/maths/matrix_exponentiation.py caused by self-referential type annotations in the Matrix class.

The Matrix.__mul__ method references Matrix in its parameter and return type annotations before the class definition has been fully evaluated. This causes Python to raise NameError: name 'Matrix' is not defined when the module is imported.

This change adds from __future__ import annotations to postpone the evaluation of type annotations, allowing the self-referential Matrix annotations to be resolved correctly without changing the algorithm's behavior.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests?
  • Documentation change?

Fixes #15075

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copilot AI lite review requested due to automatic review settings August 23, 2026 08:44
@algorithms-keeper algorithms-keeper Bot added the enhancement This PR modified some existing files label Aug 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] NameError on self-referential class type annotations in matrix_exponentiation.py

2 participants