add Test for InsertionSort#500
Merged
Merged
Conversation
varunu28
suggested changes
Aug 29, 2018
varunu28
left a comment
varunu28
left a comment
Contributor
There was a problem hiding this comment.
Can you remove print statements from the test
Author
|
@varunu28 Only this test or including other tests have print statements in my code? |
Contributor
|
@lq920320 Remove it from other ones too. I missed it in earlier reviews. We don't need a print statement in the tests. If it fails then Junit assertion generates enough logs for clarification |
delete print statements from Test files.
varunu28
approved these changes
Aug 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.