fix(typing): add -> None to __init__ methods missing return annotation - #144
Merged
Conversation
A missing return annotation makes every call site of an untyped __init__ (e.g. TeslaBluetooth) look like an untyped call to mypy, forcing downstream consumers to add type: ignore[no-untyped-call]. Annotate all __init__ methods across the package with -> None. Claude-Session: https://claude.ai/code/session_01VvadPv5MzPinGHF9WXJK6c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing return annotations on
__init__methods (e.g.TeslaBluetooth.__init__) make mypy treat every call site as an untyped call in downstream consumers (the Home Assistant integration), forcing a# type: ignore[no-untyped-call]there even though the library is fully typed otherwise. Adds-> Noneto every__init__in the package missing it.Annotation-only change; no behavior change.
ruff,pyright, and the test suite pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01VvadPv5MzPinGHF9WXJK6c