Fix#598: Ensure consistency for instruction qubits - #608
Open
thierry-martinez wants to merge 9 commits into
Open
thierry-martinez wants to merge 9 commits into
thierry-martinez wants to merge 9 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #608 +/- ##
==========================================
- Coverage 89.98% 89.96% -0.02%
==========================================
Files 49 49
Lines 8235 8224 -11
==========================================
- Hits 7410 7399 -11
Misses 825 825 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the order of the attributes of the controlled instructions to put the control qubits first, to ensure consistency with controlled instructions that already take the control qubit first, to be consistent with the matrix description of the gates, and be consistent with the
Circuitmethods that add instructions to the circuit. The modified gates are:CCXandRZZ,ControlledSingleTargetInstruction(CNOT,CY)ControlledRotationInstruction(CP,CRX,CRY,CRZ,CJ).Moreover,
CZis now aControlledSingleTargetInstructionand takes acontroland atargetinstead of a pair oftargets.