Skip to content

Feature: 2FA support with TOTP and Email verification - #189

Merged
JoryHogeveen merged 43 commits into
masterfrom
feature/2fa
Aug 20, 2026
Merged

Feature: 2FA support with TOTP and Email verification#189
JoryHogeveen merged 43 commits into
masterfrom
feature/2fa

Conversation

@JoryHogeveen

@JoryHogeveen JoryHogeveen commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #188

  • Dual Verification: Supports both TOTP (Authenticator App) and email codes during login.
  • Account Management: Secure panel for users to set up, verify, and disable 2FA.
  • Scheb Integration: Leverages scheb/2fa-bundle with a custom TwoFactor entity for credential storage.
  • Also added auth flow tests

Bonus:

This PR also fixes the env type for test environments.
It also improves the test pipeline to support webbased tests (responses etc.) by adding npm build.

@JoryHogeveen
Set no prefix flag, kernel is a root level param
f226265
@JoryHogeveen
Instal 2fa bundle with email and totp addons
c906a94
@JoryHogeveen
Create TwoFactor entity to store types
ba004b5
@JoryHogeveen
Setup basic email 2FA config
12bcee6
@JoryHogeveen
Do not specify table, generate automatically
4133e28
@JoryHogeveen
Specify as ORM entity
8ec876f
@JoryHogeveen
Create 2FA templates
cf08c1c
@JoryHogeveen
Set 2FA template path
942961f
@JoryHogeveen
Set base 2FA firewall config
1fbecce
@JoryHogeveen
Set 2fa routes config
040cdf3
@JoryHogeveen
Add 2fa methods and columns (currently only supports email and totp)
693a85d
@JoryHogeveen
Install QR generator (package suggested by 2FA bundle)
b0cd48c
@JoryHogeveen
Add TOTP method to bundle config
4c4574e
@JoryHogeveen
TwoFactor setup controller with templates. Enables the user to config…
04b7c7e 
…ure TOTP or Email 2FA.
@JoryHogeveen
Add note about GoogleAuthenticator defaults
89d3c76
@JoryHogeveen
Add 2fa setup card in account
6305df9
@JoryHogeveen
Improve button UI
bc7e83d
@JoryHogeveen
Improve 2fa setup UI and add 2fa icon
4878785
@JoryHogeveen
Set preferred 2fa method to totp if available
621eae0
@JoryHogeveen
Logout path should be publicly accessible (otherwise you cannot cance…
0d19d6f 
…l 2fa request)
@JoryHogeveen
Just mention TOTP, no need for name dropping
9426e50
@JoryHogeveen
Improve 2FA login template UI
412167e
@JoryHogeveen
Commit 2fa installation lock file changes
8409e35
@JoryHogeveen
Use slashed for 2fa routes
caa2c47
@JoryHogeveen
Create 2FA entity settings tests
e7cc7c7
@JoryHogeveen
Only set roles if provided
39c94e4
@JoryHogeveen
Add account 2FA tests for generating tokens and validating access
c1cfd7e
@JoryHogeveen
Set orphanRemoval for two factor methods
168f2c2
@JoryHogeveen
Reorder params and methods
86d76e3
@JoryHogeveen
Validate if a user already has a method of that type
05b21a2
@JoryHogeveen JoryHogeveen added this to the 0.1-rc1 milestone Aug 19, 2026
@JoryHogeveen
JoryHogeveen requested a review from NKoonen August 19, 2026 20:48
@JoryHogeveen JoryHogeveen self-assigned this Aug 19, 2026
@JoryHogeveen JoryHogeveen added priority: High Priority issue feature Related to a new feature component: Core labels Aug 19, 2026
@JoryHogeveen JoryHogeveen moved this to Testing in SyncEngine core Aug 19, 2026
NKoonen
NKoonen requested changes Aug 20, 2026
View reviewed changes
Comment thread src/Controller/Admin/AccountTwoFactorController.php Outdated
Comment thread src/Controller/Admin/AccountTwoFactorController.php Outdated
Comment thread src/Controller/Admin/AccountTwoFactorController.php
@JoryHogeveen
JoryHogeveen merged commit 441e556 into master Aug 20, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Testing to Done in SyncEngine core Aug 20, 2026
@JoryHogeveen
JoryHogeveen deleted the feature/2fa branch August 20, 2026 19:47
@JoryHogeveen
JoryHogeveen requested a review from NKoonen August 20, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NKoonen NKoonen Awaiting requested review from NKoonen

Assignees

See More

@JoryHogeveen JoryHogeveen

Labels

component: Core feature Related to a new feature priority: High Priority issue

Projects

SyncEngine core
Status: Done

Milestone

0.1-rc1

Development

Successfully merging this pull request may close these issues.

Add 2FA on admin

2 participants

@JoryHogeveen @NKoonen