Repository navigation
Add IfQueryable, for conditionally showing a view - #7
Merged
Merged
Conversation
SwiftedMind
requested changes
Jan 13, 2024
SwiftedMind
left a comment
SwiftedMind
left a comment
Owner
There was a problem hiding this comment.
Hey @KaiTheRedNinja 👋
appreciate the contribution! I really like the idea :)
I have a few comments on the PR, to clean up the implementation a bit but other than that I'd be happy to include it in the package.
Let me know if something's not clear or if you have any questions.
Thanks a lot!
SwiftedMind
requested changes
Jan 15, 2024
SwiftedMind
left a comment
SwiftedMind
left a comment
Owner
There was a problem hiding this comment.
One more change, then it should be good to do 👍
Co-authored-by: Dennis Müller <[email protected]>
SwiftedMind
approved these changes
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IfQueryableconditionally shows a view for a query.It was implemented to be similar to Queryable+overlay.
When no query is active, the IfQueryable is simply a
ZStack<EmptyView()>.