Fixes for latest PHP - #50
Merged
Merged
Conversation
Includes some regex fixes for latest PHP versions and some improved error message filtering.
kaste
reviewed
Jul 12, 2022
kaste
reviewed
Jul 12, 2022
Member
|
You don't change the E.g. |
Contributor
Author
|
Yes, this PR doesn't fix the selector issue. These were just small fixes I've had in a local branch for a long time, I just didn't get around to sending a PR for them. |
Member
|
Cool, I just merge this then. |
Member
|
FWIW I could simplify the tests further (0d75578) so that they don't leak implementation details. Thanks for nudging in the right direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes some regex fixes for latest PHP versions and some improved error message filtering.
Re: #48 (comment)