Repository navigation
Fix(AssetManager): Pass the required title to URLRow in InfoPage - #672
Open
marvin1099 wants to merge 1 commit into
Open
marvin1099 wants to merge 1 commit into
marvin1099 wants to merge 1 commit into
Conversation
0f43996 renamed OriginalURL to URLRow and made title a required argument. The call sites in Store/InfoPage.py were updated, and the import in AssetManager/InfoPage.py was updated too, but the call was left as URLRow() and now raises TypeError as soon as the Asset Manager info page builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #670
0f43996renamedOriginalURL→URLRowand madetitlea required argument. The two call sites inStore/InfoPage.pywere updated, and the import inAssetManager/InfoPage.pywas updated too, but the call itself was left asURLRow().So opening an asset in the Asset Manager raises straight away:
One-line fix, using the same title the old
OriginalURLhardcoded:self.license_url_row = AttributeRow(title="URL:", attr="Error") self.license_group.add(self.license_url_row) - self.original_url_row = URLRow() + self.original_url_row = URLRow(title="Original URL:") self.license_group.add(self.original_url_row)While in there:
show_for_asset()fills in every other row on that page but never sets this one, so it would render "N/A" for store assets. Possibly intentional, so I've left it alone.