Skip to content

Improve window grabber support for swaywm #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Core447 merged 1 commit into from
Dec 23, 2024
Merged

Improve window grabber support for swaywm #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/backend/WindowGrabber/Integrations/Sway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,17 @@ def get_active_window(self) -> Window:
continue
return self._parse_window(client)

def _walk_tree(self, node, windows: list[dict[str, Any]]):
if "window_properties" in node or "app_id" in node:
# Try to only add actual windows
windows.append(node)

if "nodes" in node:
for child in node.get("nodes"):
self._walk_tree(child, windows)
for child in node.get("floating_nodes"):
self._walk_tree(child, windows)

def _get_windows(self) -> list[dict[str, Any]]:
windows = []
try:
Expand All @@ -70,10 +81,7 @@ def _get_windows(self) -> list[dict[str, Any]]:

for output in clients.get("nodes", []):
for workspace in output.get("nodes", []):
for client in workspace.get("nodes", []):
windows.append(client)
for client in workspace.get("floating_nodes", []):
windows.append(client)
self._walk_tree(workspace, windows)

except subprocess.CalledProcessError as e:
log.error(f"An error occurred while running swaymsg: {e}")
Expand Down