Repository navigation
Conversation
nazbert
added a commit
to nazbert/Deckard
that referenced
this pull request
Jul 12, 2026
…reamController#19) close() (load/teardown threads via close_resources()) nulled self.video_cache while a render tick could be between its multiple video_cache reads -> AttributeError on None (logged via the action-callback catch). Worse than the logged error: a get_frame() that merely STARTS after the reader is released can resurrect a cv2.VideoCapture through Mp4FrameCache._maybe_adopt_shared_cache and leak it, so a bare snapshot isn't enough. Add a per-instance lock with a check-then-hold pattern: an unlocked None peek keeps post-close stragglers free, the body holds the lock for the whole pick+decode so close() waits for an in-flight frame, and no frame begins against a released reader. Uncontended acquire per tick is noise next to the frame decode; close() stays idempotent. Test: tests/scenario_keyvideo_close_race.py (150-round close-vs-tick hammer over a sleep-widened stub cache: no exceptions, zero cache accesses after release, quiet None afterwards; plus a real mp4_tile_cache-registry InputVideo closed under concurrent ticks). scenario_keyvideo_build's __new__ factory sets the new lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.