You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
BUG: TypeError: URLRow() missing required 'title' in AssetManager InfoPage (regression from 0f43996) #670
Trying to pick an icon or wallpaper in the Asset Manager throws an exception and the info page never opens.
This started with 0f43996 ("InfoPage: Add new source row"), which is currently the tip of main.
To Reproduce
Run from source at HEAD
Open an asset so the Asset Manager window appears
See error
Expected behavior
The info page opens.
Additional context
File ".../src/windows/AssetManager/InfoPage.py", line 70, in build
self.original_url_row = URLRow()
TypeError: URLRow.__init__() missing 1 required positional argument: 'title'
That same commit renamed OriginalURL → URLRow and made title a required argument. The two call sites in Store/InfoPage.py were updated, and AssetManager/InfoPage.py got updated too, just nobody passed title there.
(Might be worth a look while you're in there: show_for_asset() fills in every other row on that page but never sets this one, so it would show "N/A" for store assets. Could well be intentional.)
Activity