Skip to content

BUG: TypeError: URLRow() missing required 'title' in AssetManager InfoPage (regression from 0f43996) #670

Open

Description

@marvin1099

Describe the bug

Trying to pick an icon or wallpaper in the Asset Manager throws an exception and the info page never opens.

This started with 0f43996 ("InfoPage: Add new source row"), which is currently the tip of main.

To Reproduce

  1. Run from source at HEAD
  2. Open an asset so the Asset Manager window appears
  3. See error

Expected behavior

The info page opens.

Additional context

File ".../src/windows/AssetManager/InfoPage.py", line 70, in build
    self.original_url_row = URLRow()
TypeError: URLRow.__init__() missing 1 required positional argument: 'title'

That same commit renamed OriginalURL → URLRow and made title a required argument. The two call sites in Store/InfoPage.py were updated, and AssetManager/InfoPage.py got updated too, just nobody passed title there.

One line fixes it:

-        self.original_url_row = URLRow()
+        self.original_url_row = URLRow(title="Original URL:")

(Might be worth a look while you're in there: show_for_asset() fills in every other row on that page but never sets this one, so it would show "N/A" for store assets. Could well be intentional.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    • Status
      No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions