Deck Settings Brightness overrides Page Overwrite default deck brightness #180

Activity

1. KaJe5380

   added

   bugSomething isn't workingSomething isn't working

   on Jul 19, 2024
2. github-project-automation

   added this to Devon Jul 19, 2024
3. Core447 commented on Jul 20, 2024

   

   Core447

   on Jul 20, 2024

   Last edited by Core447

   Member

   More actions

   Fixed with ed9c34c, we can keep this opened until it's available on the Flatpak

   Update: Seems still broken in some cases

   👍React with 👍1Reacted by KaJe
4. KaJe5380 commented on Jul 20, 2024

   

   KaJe5380

   on Jul 20, 2024

   Last edited by KaJe5380

   Author

   More actions

   2024-07-20 03:59:17.194 | ERROR    | src.windows.mainWindow.elements.PageSettings.DeckGroup:on_toggle_overwrite:137 - An error has been caught in function 'on_toggle_overwrite', process 'MainProcess' (3), thread 'MainThread' (131776685471552):
   Traceback (most recent call last):
   
     File "/app/bin/StreamController/main.py", line 276, in <module>
       main()
       └ <function main at 0x77d95fd4e020>
   
     File "/app/bin/StreamController/main.py", line 273, in main
       load()
       └ <function load at 0x77d95fd4cf40>
   
     File "/app/bin/StreamController/main.py", line 99, in load
       gl.main = Main(application_id="com.core447.StreamController", deck_manager=gl.deck_manager)
       │         │                                                                │  └ <src.backend.DeckManagement.DeckManager.DeckManager object at 0x77d9465abf50>
       │         │                                                                └ <module 'globals' from '/app/bin/StreamController/globals.py'>
       │         └ <class '__main__.Main'>
       └ <module 'globals' from '/app/bin/StreamController/globals.py'>
   
     File "/app/bin/StreamController/main.py", line 90, in __init__
       self.app.run(gl.argparser.parse_args().app_args)
       │    │   │   │  │         └ <function ArgumentParser.parse_args at 0x77d9a508b380>
       │    │   │   │  └ ArgumentParser(prog='main.py', usage=None, description=None, formatter_class=<class 'argparse.HelpFormatter'>, conflict_handl...
       │    │   │   └ <module 'globals' from '/app/bin/StreamController/globals.py'>
       │    │   └ <function Application.run at 0x77d9a3d3c040>
       │    └ <app.App object at 0x77d952b61580 (src+app+App at 0x59067bd4d420)>
       └ <__main__.Main object at 0x77d94792de10>
   
     File "/usr/lib/python3.11/site-packages/gi/overrides/Gio.py", line 42, in run
       return Gio.Application.run(self, *args, **kwargs)
              │   │           │   │      │       └ {}
              │   │           │   │      └ ([],)
              │   │           │   └ <app.App object at 0x77d952b61580 (src+app+App at 0x59067bd4d420)>
              │   │           └ gi.FunctionInfo(run, bound=None)
              │   └ <class 'gi.repository.Gio.Application'>
              └ <IntrospectionModule 'Gio' from '/usr/lib/x86_64-linux-gnu/girepository-1.0/Gio-2.0.typelib'>
   
     File "/app/bin/StreamController/src/backend/DeckManagement/DeckController.py", line 629, in update_ui_on_page_change
       settings_group.brightness.load_defaults_from_page()
       │              │          └ <function Brightness.load_defaults_from_page at 0x77d97a196840>
       │              └ <DeckGroup.Brightness object at 0x77d946174040 (src+windows+mainWindow+elements+PageSettings+DeckGroup+Brightness at 0x59067b...
       └ <DeckGroup.DeckGroup object at 0x77d946174d80 (src+windows+mainWindow+elements+PageSettings+DeckGroup+DeckGroup at 0x59067be3...
   
     File "/app/bin/StreamController/src/windows/mainWindow/elements/PageSettings/DeckGroup.py", line 152, in load_defaults_from_page
       self.overwrite_switch.set_active(active)
       │    │                │          └ True
       │    │                └ gi.FunctionInfo(set_active, bound=None)
       │    └ <Gtk.Switch object at 0x77d9461720c0 (GtkSwitch at 0x59067bf4fd10)>
       └ <DeckGroup.Brightness object at 0x77d946174040 (src+windows+mainWindow+elements+PageSettings+DeckGroup+Brightness at 0x59067b...
   
   > File "/app/bin/StreamController/src/windows/mainWindow/elements/PageSettings/DeckGroup.py", line 137, in on_toggle_overwrite
       deck_controller.load_page(deck_controller.active_page, load_screensaver=False, load_background=False, load_keys=False)
       │               │         │               └ <src.backend.PageManagement.Page.Page object at 0x77d94617c310>
       │               │         └ <src.backend.DeckManagement.DeckController.DeckController object at 0x77d946107550>
       │               └ <function DeckController.load_page at 0x77d96cfbe700>
       └ <src.backend.DeckManagement.DeckController.DeckController object at 0x77d946107550>
   
   TypeError: DeckController.load_page() got an unexpected keyword argument 'load_keys'
   
   

   It happens randomly when swapping between two pages.
   One with overwrite brightness of 80 and the other being 4.
   Seems to be when swapping from a page that has overwrite and another that doesn't have an overwrite.
5. Core447 commented on Jul 20, 2024

   

   Core447

   on Jul 20, 2024

   Member

   More actions

   It happens randomly when swapping between two pages.
   One with overwrite brightness of 80 and the other being 4.
   Seems to be when swapping from a page that has overwrite and another that doesn't have an overwrite.

   Fixed with 54dde86

   👍React with 👍1Reacted by KaJe
6. zeridon commented on Sep 17, 2024

   

   zeridon

   on Sep 17, 2024

   Contributor

   More actions

   Seems that this is happening if you ever tried to set custom brightness per page (you are switching to).

   e.g. with:

       "brightness": {
           "overwrite": false,
           "value": 30
       },
   

   in a page i see the brightness flash. Without it i do not.

   👀React with 👀1Reacted by KaJe
7. ImDevinC commented on Oct 13, 2025

   

   ImDevinC

   on Oct 13, 2025

   Contributor

   More actions

   I can no longer reproduce this issue. Closing as it should be resolved and we've received no feedback otherwise. Feel free to comment if you can still reproduce
8. ImDevinC

   closed this as completedon Oct 13, 2025
9. nazbert

   added 5 commits that reference this issue on Aug 9, 2026

   perf(store): defer read-clock index writes behind a debounced flush (…

   ...

   cb93b5e

   test(store): pin the store cache index flush semantics (refs StreamCo…

   ...

   be26d7f

   fix(store): put the quit flush behind the watchdog and harden the deb…

   ...

   59d5082

   test(store): pin the quit drain, the atexit hook and the timer dedupe…

   ...

   0152fbe

   Merge branch 'perf/180-storecache-index-flush' into 'main'

   ...

   7a019fd