Fix missing runner in Linux selective build and custom ops jobs#313
Closed
huydhn wants to merge 2 commits into
Closed
Fix missing runner in Linux selective build and custom ops jobs#313huydhn wants to merge 2 commits into
huydhn wants to merge 2 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
huydhn
changed the title
Contributor
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mistakenly replace this in #277. The runner is not set here, and causes syntax error, for example https://github.com/pytorch/executorch/actions/runs/6167285165. The workflow still works because the default
linux.2xlargeis used (same runner type)Testing
The annotation error is gone now https://github.com/pytorch/executorch/actions/runs/6175961826